Re: [PATCH] mm: remove the redundancy code

2020-06-30 Thread David Hildenbrand
On 29.06.20 19:30, Su Hui wrote: > remove the redundancy code, the zone_start_pfn > is assigned from zone->zone_start_pfn > Signed-off-by: Su Hui > --- Side note: You should really work on better patch subjects/descriptions. + casing, punctuation, empty line before Signed-off-by ... "mm: remove

Re: [PATCH] mm: remove the redundancy code

2020-06-30 Thread kernel test robot
Hi Su, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mmotm/master] url: https://github.com/0day-ci/linux/commits/Su-Hui/mm-remove-the-redundancy-code/20200630-013137 base: git://git.cmpxchg.org/linux-mmotm.git master config: x86_64-allnoconfig

Re: [PATCH] mm: remove the redundancy code

2020-06-30 Thread kernel test robot
Hi Su, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mmotm/master] url: https://github.com/0day-ci/linux/commits/Su-Hui/mm-remove-the-redundancy-code/20200630-013137 base: git://git.cmpxchg.org/linux-mmotm.git master config: x86_64-allnoconfig

Re:Re:Re: [PATCH] mm: remove the redundancy code

2020-06-29 Thread 苏辉
I did not find bug here, and i was just confused when I saw the code.Thanks. At 2020-06-30 10:06:55, "David Rientjes" wrote: >On Tue, 30 Jun 2020, 苏辉 wrote: > >> I am sorry that i did not consider the memory hotplug case, >> and i think we should add a new param to distinguish two different

Re:Re: [PATCH] mm: remove the redundancy code

2020-06-29 Thread David Rientjes
On Tue, 30 Jun 2020, 苏辉 wrote: > I am sorry that i did not consider the memory hotplug case, > and i think we should add a new param to distinguish two different cases. > No need, we can simply continue setting zone->zone_start_pfn unless there is a bug to be fixed (and, if so, please send a

Re: [PATCH] mm: remove the redundancy code

2020-06-29 Thread David Rientjes
On Tue, 30 Jun 2020, Su Hui wrote: > remove the redundancy code, the zone_start_pfn > is assigned from zone->zone_start_pfn > Signed-off-by: Su Hui I don't think this is redundant, it's used by memory hotplug when onlining new memory. > --- > mm/page_alloc.c | 2 -- > 1 file changed, 2

Re: [PATCH] mm: remove the redundancy code

2020-06-29 Thread Mike Rapoport
On Mon, Jun 29, 2020 at 11:50:15AM -0700, David Rientjes wrote: > On Tue, 30 Jun 2020, Su Hui wrote: > > > remove the redundancy code, the zone_start_pfn > > is assigned from zone->zone_start_pfn > > Signed-off-by: Su Hui > > I don't think this is redundant, it's used by memory hotplug when

[PATCH] mm: remove the redundancy code

2020-06-29 Thread Su Hui
remove the redundancy code, the zone_start_pfn is assigned from zone->zone_start_pfn Signed-off-by: Su Hui --- mm/page_alloc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3c4eb750a199..3372a8c9fbc4 100644 --- a/mm/page_alloc.c +++