Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-17 Thread Heesub Shin
Hello, On 06/17/2013 09:08 AM, Dave Chinner wrote: On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: shrink_slab() queries each slab cache to get the number of elements in it. In most cases such queries are cheap but, on some caches. For example, Android low-memory-killer, which is

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-17 Thread Heesub Shin
Hello, On 06/17/2013 09:08 AM, Dave Chinner wrote: On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: shrink_slab() queries each slab cache to get the number of elements in it. In most cases such queries are cheap but, on some caches. For example, Android low-memory-killer, which is

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-16 Thread Dave Chinner
On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: > shrink_slab() queries each slab cache to get the number of > elements in it. In most cases such queries are cheap but, > on some caches. For example, Android low-memory-killer, > which is operates as a slab shrinker, does relatively >

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-16 Thread Dave Chinner
On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: shrink_slab() queries each slab cache to get the number of elements in it. In most cases such queries are cheap but, on some caches. For example, Android low-memory-killer, which is operates as a slab shrinker, does relatively long

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-15 Thread Minchan Kim
Hello, Andrew want to merge this so I try to review. On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: > shrink_slab() queries each slab cache to get the number of > elements in it. In most cases such queries are cheap but, > on some caches. For example, Android low-memory-killer, >

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-15 Thread Minchan Kim
Hello Andrew, On Fri, Jun 14, 2013 at 04:04:25PM -0700, Andrew Morton wrote: > On Sat, 15 Jun 2013 03:13:26 +0900 HeeSub Shin wrote: > > > Hello, > > > > On Fri, Jun 14, 2013 at 8:10 PM, Minchan Kim wrote: > > > > > > > > Hello, > > > > > > On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-15 Thread Minchan Kim
Hello Andrew, On Fri, Jun 14, 2013 at 04:04:25PM -0700, Andrew Morton wrote: On Sat, 15 Jun 2013 03:13:26 +0900 HeeSub Shin hee...@gmail.com wrote: Hello, On Fri, Jun 14, 2013 at 8:10 PM, Minchan Kim minc...@kernel.org wrote: Hello, On Fri, Jun 14, 2013 at 07:07:51PM

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-15 Thread Minchan Kim
Hello, Andrew want to merge this so I try to review. On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: shrink_slab() queries each slab cache to get the number of elements in it. In most cases such queries are cheap but, on some caches. For example, Android low-memory-killer, which

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-14 Thread Kyungmin Park
On Sat, Jun 15, 2013 at 8:04 AM, Andrew Morton wrote: > > On Sat, 15 Jun 2013 03:13:26 +0900 HeeSub Shin wrote: > > > Hello, > > > > On Fri, Jun 14, 2013 at 8:10 PM, Minchan Kim wrote: > > > > > > > > Hello, > > > > > > On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: > > > >

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-14 Thread Andrew Morton
On Sat, 15 Jun 2013 03:13:26 +0900 HeeSub Shin wrote: > Hello, > > On Fri, Jun 14, 2013 at 8:10 PM, Minchan Kim wrote: > > > > > Hello, > > > > On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: > > > shrink_slab() queries each slab cache to get the number of > > > elements in it.

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-14 Thread Minchan Kim
Hello, On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: > shrink_slab() queries each slab cache to get the number of > elements in it. In most cases such queries are cheap but, > on some caches. For example, Android low-memory-killer, > which is operates as a slab shrinker, does

[PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-14 Thread Heesub Shin
shrink_slab() queries each slab cache to get the number of elements in it. In most cases such queries are cheap but, on some caches. For example, Android low-memory-killer, which is operates as a slab shrinker, does relatively long calculation once invoked and it is quite expensive. This patch

[PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-14 Thread Heesub Shin
shrink_slab() queries each slab cache to get the number of elements in it. In most cases such queries are cheap but, on some caches. For example, Android low-memory-killer, which is operates as a slab shrinker, does relatively long calculation once invoked and it is quite expensive. This patch

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-14 Thread Minchan Kim
Hello, On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: shrink_slab() queries each slab cache to get the number of elements in it. In most cases such queries are cheap but, on some caches. For example, Android low-memory-killer, which is operates as a slab shrinker, does

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-14 Thread Andrew Morton
On Sat, 15 Jun 2013 03:13:26 +0900 HeeSub Shin hee...@gmail.com wrote: Hello, On Fri, Jun 14, 2013 at 8:10 PM, Minchan Kim minc...@kernel.org wrote: Hello, On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: shrink_slab() queries each slab cache to get the number of

Re: [PATCH] mm: vmscan: remove redundant querying to shrinker

2013-06-14 Thread Kyungmin Park
On Sat, Jun 15, 2013 at 8:04 AM, Andrew Morton a...@linux-foundation.org wrote: On Sat, 15 Jun 2013 03:13:26 +0900 HeeSub Shin hee...@gmail.com wrote: Hello, On Fri, Jun 14, 2013 at 8:10 PM, Minchan Kim minc...@kernel.org wrote: Hello, On Fri, Jun 14, 2013 at 07:07:51PM