On Mon, 14 Mar 2005, Andrew Morton wrote:
> > Then you wont be able to get rid of the counters by
> >
> > #define MM_COUNTER(xx)
> >
> > anymore.
>
> Why would we want to do that?
If counters are calculated on demand then no counter is
necessary.
-
To unsubscribe from this list: send the
Christoph Lameter <[EMAIL PROTECTED]> wrote:
>
> On Mon, 14 Mar 2005, Andrew Morton wrote:
>
> > I don't think the MM_COUNTER_T macro adds much, really. How about this?
>
> Then you wont be able to get rid of the counters by
>
> #define MM_COUNTER(xx)
>
> anymore.
Why would we want to do
On Mon, 14 Mar 2005, Andrew Morton wrote:
> I don't think the MM_COUNTER_T macro adds much, really. How about this?
Then you wont be able to get rid of the counters by
#define MM_COUNTER(xx)
anymore.
>
> --- 25/include/linux/sched.h~mm-counter-operations-through-macros-tidy
>
Christoph Lameter <[EMAIL PROTECTED]> wrote:
>
> This patch extracts all the operations on counters protected by the
> page table lock (currently rss and anon_rss) into definitions in
> include/linux/sched.h. All rss operations are performed through
> the following macros:
I don't think the
Ok. Here is an updated patch:
This patch extracts all the operations on counters protected by the
page table lock (currently rss and anon_rss) into definitions in
include/linux/sched.h. All rss operations are performed through
the following macros:
get_mm_counter(mm, member) ->
Ok. Here is an updated patch:
This patch extracts all the operations on counters protected by the
page table lock (currently rss and anon_rss) into definitions in
include/linux/sched.h. All rss operations are performed through
the following macros:
get_mm_counter(mm, member) -
Christoph Lameter [EMAIL PROTECTED] wrote:
This patch extracts all the operations on counters protected by the
page table lock (currently rss and anon_rss) into definitions in
include/linux/sched.h. All rss operations are performed through
the following macros:
I don't think the
On Mon, 14 Mar 2005, Andrew Morton wrote:
I don't think the MM_COUNTER_T macro adds much, really. How about this?
Then you wont be able to get rid of the counters by
#define MM_COUNTER(xx)
anymore.
--- 25/include/linux/sched.h~mm-counter-operations-through-macros-tidy
2005-03-14
Christoph Lameter [EMAIL PROTECTED] wrote:
On Mon, 14 Mar 2005, Andrew Morton wrote:
I don't think the MM_COUNTER_T macro adds much, really. How about this?
Then you wont be able to get rid of the counters by
#define MM_COUNTER(xx)
anymore.
Why would we want to do that?
-
To
On Mon, 14 Mar 2005, Andrew Morton wrote:
Then you wont be able to get rid of the counters by
#define MM_COUNTER(xx)
anymore.
Why would we want to do that?
If counters are calculated on demand then no counter is
necessary.
-
To unsubscribe from this list: send the line
Christoph Lameter writes:
> On Fri, 11 Mar 2005, Dave Jones wrote:
>
> > Splitting this last one into inc_mm_counter() and dec_mm_counter()
> > means you can kill off the last argument, and get some of the
> > readability back. As it stands, I think this patch adds a bunch
> > of
Christoph Lameter writes:
On Fri, 11 Mar 2005, Dave Jones wrote:
Splitting this last one into inc_mm_counter() and dec_mm_counter()
means you can kill off the last argument, and get some of the
readability back. As it stands, I think this patch adds a bunch
of obfuscation for no
On Fri, 11 Mar 2005, Andrew Morton wrote:
> > +#define set_mm_counter(mm, member, value) (mm)->member = (value)
> > +#define get_mm_counter(mm, member) ((mm)->member)
> > +#define update_mm_counter(mm, member, value) (mm)->member += (value)
> > +#define inc_mm_counter(mm, member) (mm)->member++
>
Christoph Lameter <[EMAIL PROTECTED]> wrote:
>
> This patch extracts all the operations on counters protected by the
> page table lock (currently rss and anon_rss) into definitions in
> include/linux/sched.h. All rss operations are performed through
> the following macros:
>
> get_mm_counter(mm,
On Fri, 11 Mar 2005, Dave Jones wrote:
> Splitting this last one into inc_mm_counter() and dec_mm_counter()
> means you can kill off the last argument, and get some of the
> readability back. As it stands, I think this patch adds a bunch
> of obfuscation for no clear benefit.
Ok.
On Fri, Mar 11, 2005 at 04:23:21AM -0800, Christoph Lameter wrote:
> This patch extracts all the operations on counters protected by the
> page table lock (currently rss and anon_rss) into definitions in
> include/linux/sched.h. All rss operations are performed through
> the following three
This patch extracts all the operations on counters protected by the
page table lock (currently rss and anon_rss) into definitions in
include/linux/sched.h. All rss operations are performed through
the following three macros:
get_mm_counter(mm, member) -> Obtain the value of a counter
This patch extracts all the operations on counters protected by the
page table lock (currently rss and anon_rss) into definitions in
include/linux/sched.h. All rss operations are performed through
the following three macros:
get_mm_counter(mm, member) - Obtain the value of a counter
On Fri, Mar 11, 2005 at 04:23:21AM -0800, Christoph Lameter wrote:
This patch extracts all the operations on counters protected by the
page table lock (currently rss and anon_rss) into definitions in
include/linux/sched.h. All rss operations are performed through
the following three
On Fri, 11 Mar 2005, Dave Jones wrote:
Splitting this last one into inc_mm_counter() and dec_mm_counter()
means you can kill off the last argument, and get some of the
readability back. As it stands, I think this patch adds a bunch
of obfuscation for no clear benefit.
Ok.
Christoph Lameter [EMAIL PROTECTED] wrote:
This patch extracts all the operations on counters protected by the
page table lock (currently rss and anon_rss) into definitions in
include/linux/sched.h. All rss operations are performed through
the following macros:
get_mm_counter(mm, member)
On Fri, 11 Mar 2005, Andrew Morton wrote:
+#define set_mm_counter(mm, member, value) (mm)-member = (value)
+#define get_mm_counter(mm, member) ((mm)-member)
+#define update_mm_counter(mm, member, value) (mm)-member += (value)
+#define inc_mm_counter(mm, member) (mm)-member++
+#define
22 matches
Mail list logo