Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

在 2016/5/26 11:59, Jaehoon Chung 写道: On 05/26/2016 11:23 AM, Shawn Lin wrote: Hi Jaehoon, On 2016/5/19 21:07, Jaehoon Chung wrote: On 05/19/2016 08:31 PM, Shawn Lin wrote: Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

在 2016/5/26 11:59, Jaehoon Chung 写道: On 05/26/2016 11:23 AM, Shawn Lin wrote: Hi Jaehoon, On 2016/5/19 21:07, Jaehoon Chung wrote: On 05/19/2016 08:31 PM, Shawn Lin wrote: Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: Hi On 2016-5-18

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

On 05/26/2016 11:23 AM, Shawn Lin wrote: > Hi Jaehoon, > > On 2016/5/19 21:07, Jaehoon Chung wrote: >> On 05/19/2016 08:31 PM, Shawn Lin wrote: >>> Hi, >>> >>> On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

On 05/26/2016 11:23 AM, Shawn Lin wrote: > Hi Jaehoon, > > On 2016/5/19 21:07, Jaehoon Chung wrote: >> On 05/19/2016 08:31 PM, Shawn Lin wrote: >>> Hi, >>> >>> On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: > Hi > >

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi Jaehoon, On 2016/5/19 21:07, Jaehoon Chung wrote: On 05/19/2016 08:31 PM, Shawn Lin wrote: Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17,

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi Jaehoon, On 2016/5/19 21:07, Jaehoon Chung wrote: On 05/19/2016 08:31 PM, Shawn Lin wrote: Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

On 05/19/2016 08:31 PM, Shawn Lin wrote: > Hi, > > On 2016/5/19 1:37, Doug Anderson wrote: >> Hi, >> >> On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: >>> Hi >>> >>> >>> On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM,

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

On 05/19/2016 08:31 PM, Shawn Lin wrote: > Hi, > > On 2016/5/19 1:37, Doug Anderson wrote: >> Hi, >> >> On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: >>> Hi >>> >>> >>> On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote:

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: Could you try this patch to see

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On 2016/5/19 1:37, Doug Anderson wrote: Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: Could you try this patch to see if you can still find HLE? @@ -2356,12 +2356,22 @@

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Am Mittwoch, 18. Mai 2016, 10:37:52 schrieb Doug Anderson: > Note: I'd be very curious if your problems get better if you disable > the "grf_force_jtag" bit in the GRF. If you're using the builtin card > detect and you use the boot default of "grf_force_jtag" then your pins > will be unmuxed

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Am Mittwoch, 18. Mai 2016, 10:37:52 schrieb Doug Anderson: > Note: I'd be very curious if your problems get better if you disable > the "grf_force_jtag" bit in the GRF. If you're using the builtin card > detect and you use the boot default of "grf_force_jtag" then your pins > will be unmuxed

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: > Hi > > > On 2016-5-18 12:12, Doug Anderson wrote: >> >> Hi, >> >> On Tue, May 17, 2016 at 6:59 PM, Shawn Lin >> wrote: >>> >>> Could you try this patch to see if you can still find

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On Wed, May 18, 2016 at 2:14 AM, Shawn Lin wrote: > Hi > > > On 2016-5-18 12:12, Doug Anderson wrote: >> >> Hi, >> >> On Tue, May 17, 2016 at 6:59 PM, Shawn Lin >> wrote: >>> >>> Could you try this patch to see if you can still find HLE? >>> >>> @@ -2356,12 +2356,22 @@ static void

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: Could you try this patch to see if you can still find HLE? @@ -2356,12 +2356,22 @@ static void dw_mci_cmd_interrupt(struct dw_mci *host, u32 status) static void

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi On 2016-5-18 12:12, Doug Anderson wrote: Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: Could you try this patch to see if you can still find HLE? @@ -2356,12 +2356,22 @@ static void dw_mci_cmd_interrupt(struct dw_mci *host, u32 status) static void dw_mci_handle_cd(struct dw_mci

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On Tue, May 17, 2016 at 7:08 PM, Jaehoon Chung wrote: > On 05/18/2016 09:47 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: >>> Jaehoon, >>> >>> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On Tue, May 17, 2016 at 7:08 PM, Jaehoon Chung wrote: > On 05/18/2016 09:47 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: >>> Jaehoon, >>> >>> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung >>> wrote: Dear Doug, I'm

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: > Could you try this patch to see if you can still find HLE? > > @@ -2356,12 +2356,22 @@ static void dw_mci_cmd_interrupt(struct dw_mci > *host, u32 status) > static void dw_mci_handle_cd(struct dw_mci *host) >

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On Tue, May 17, 2016 at 6:59 PM, Shawn Lin wrote: > Could you try this patch to see if you can still find HLE? > > @@ -2356,12 +2356,22 @@ static void dw_mci_cmd_interrupt(struct dw_mci > *host, u32 status) > static void dw_mci_handle_cd(struct dw_mci *host) > { > int i; > +

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

On 05/18/2016 09:47 AM, Doug Anderson wrote: > Jaehoon, > > On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung >> wrote: >>> Dear Doug, >>> >>> I'm considering to control HLE

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

On 05/18/2016 09:47 AM, Doug Anderson wrote: > Jaehoon, > > On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung >> wrote: >>> Dear Doug, >>> >>> I'm considering to control HLE error..So holding this patch. >>> If this is

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi Doug, On 2016-5-18 8:47, Doug Anderson wrote: Jaehoon, On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: Jaehoon, On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: Dear Doug, I'm considering to control HLE error..So holding this

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi Doug, On 2016-5-18 8:47, Doug Anderson wrote: Jaehoon, On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: Jaehoon, On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: Dear Doug, I'm considering to control HLE error..So holding this patch. If this is absolutely necessary patch,

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Jaehoon, On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: > Jaehoon, > > On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: >> Dear Doug, >> >> I'm considering to control HLE error..So holding this patch. >> If this is absolutely necessary

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Jaehoon, On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: > Jaehoon, > > On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: >> Dear Doug, >> >> I'm considering to control HLE error..So holding this patch. >> If this is absolutely necessary patch, let me know, plz. >> >> Best Regards, >>

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Jaehoon, On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: > Dear Doug, > > I'm considering to control HLE error..So holding this patch. > If this is absolutely necessary patch, let me know, plz. > > Best Regards, > Jaehoon Chung Sounds OK. I have certainly applied this locally and the

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Jaehoon, On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Dear Doug, I'm considering to control HLE error..So holding this patch. If this is absolutely necessary patch, let me know, plz. Best Regards, Jaehoon Chung Sounds OK. I have certainly applied this

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Dear Doug, I'm considering to control HLE error..So holding this patch. If this is absolutely necessary patch, let me know, plz. Best Regards, Jaehoon Chung On 03/16/2015 02:56 PM, Jaehoon Chung wrote: > Hi, Doug. > > On 03/14/2015 05:27 AM, Doug Anderson wrote: >> Hi, >> >> On Fri, Mar 13,

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Dear Doug, I'm considering to control HLE error..So holding this patch. If this is absolutely necessary patch, let me know, plz. Best Regards, Jaehoon Chung On 03/16/2015 02:56 PM, Jaehoon Chung wrote: Hi, Doug. On 03/14/2015 05:27 AM, Doug Anderson wrote: Hi, On Fri, Mar 13, 2015 at

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, Doug. On 03/14/2015 05:27 AM, Doug Anderson wrote: > Hi, > > On Fri, Mar 13, 2015 at 4:30 AM, Jaehoon Chung wrote: >> Hi, Doug. >> >> On 03/11/2015 12:48 AM, Doug Anderson wrote: >>> The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but >>> nothing in the interrupt handler

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, Doug. On 03/14/2015 05:27 AM, Doug Anderson wrote: Hi, On Fri, Mar 13, 2015 at 4:30 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Doug. On 03/11/2015 12:48 AM, Doug Anderson wrote: The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but nothing in the interrupt

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On Fri, Mar 13, 2015 at 4:30 AM, Jaehoon Chung wrote: > Hi, Doug. > > On 03/11/2015 12:48 AM, Doug Anderson wrote: >> The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but >> nothing in the interrupt handler actually handles them and ACKs them. >> That means that if we ever

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, Doug. On 03/11/2015 12:48 AM, Doug Anderson wrote: > The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but > nothing in the interrupt handler actually handles them and ACKs them. > That means that if we ever get an HLE error we'll just keep getting > interrupts and we'll

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, On Fri, Mar 13, 2015 at 4:30 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Doug. On 03/11/2015 12:48 AM, Doug Anderson wrote: The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but nothing in the interrupt handler actually handles them and ACKs them. That means

Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

Hi, Doug. On 03/11/2015 12:48 AM, Doug Anderson wrote: The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but nothing in the interrupt handler actually handles them and ACKs them. That means that if we ever get an HLE error we'll just keep getting interrupts and we'll wedge

[PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but nothing in the interrupt handler actually handles them and ACKs them. That means that if we ever get an HLE error we'll just keep getting interrupts and we'll wedge things. We really don't expect HLE errors but if we ever get

[PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors

The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but nothing in the interrupt handler actually handles them and ACKs them. That means that if we ever get an HLE error we'll just keep getting interrupts and we'll wedge things. We really don't expect HLE errors but if we ever get