Re: [PATCH] mmc: dw_mmc: Don't send clock off command if power is off

2015-03-27 Thread Jaehoon Chung
Hi, On 03/23/2015 06:59 AM, Doug Anderson wrote: > Alim, > > On Sun, Mar 22, 2015 at 5:16 AM, Alim Akhtar wrote: >>> case MMC_POWER_OFF: >>> - /* Turn clock off before power goes down */ >>> - dw_mci_setup_bus(slot, false); >>> + /* Turn clock

Re: [PATCH] mmc: dw_mmc: Don't send clock off command if power is off

2015-03-27 Thread Jaehoon Chung
Hi, On 03/23/2015 06:59 AM, Doug Anderson wrote: Alim, On Sun, Mar 22, 2015 at 5:16 AM, Alim Akhtar alim.akh...@gmail.com wrote: case MMC_POWER_OFF: - /* Turn clock off before power goes down */ - dw_mci_setup_bus(slot, false); + /* Turn

Re: [PATCH] mmc: dw_mmc: Don't send clock off command if power is off

2015-03-22 Thread Doug Anderson
Alim, On Sun, Mar 22, 2015 at 5:16 AM, Alim Akhtar wrote: >> case MMC_POWER_OFF: >> - /* Turn clock off before power goes down */ >> - dw_mci_setup_bus(slot, false); >> + /* Turn clock off before power goes down; only if powered */ >> +

Re: [PATCH] mmc: dw_mmc: Don't send clock off command if power is off

2015-03-22 Thread Alim Akhtar
Hi Doug, On Fri, Mar 20, 2015 at 11:30 PM, Doug Anderson wrote: > We've already seen that it causes failures if we try to send the > "SDMMC_CMD_UPD_CLK" command when power is off to the system. Here's > another case where we were doing it: we were sending an > SDMMC_CMD_UPD_CLK to set the clock

Re: [PATCH] mmc: dw_mmc: Don't send clock off command if power is off

2015-03-22 Thread Alim Akhtar
Hi Doug, On Fri, Mar 20, 2015 at 11:30 PM, Doug Anderson diand...@chromium.org wrote: We've already seen that it causes failures if we try to send the SDMMC_CMD_UPD_CLK command when power is off to the system. Here's another case where we were doing it: we were sending an SDMMC_CMD_UPD_CLK

Re: [PATCH] mmc: dw_mmc: Don't send clock off command if power is off

2015-03-22 Thread Doug Anderson
Alim, On Sun, Mar 22, 2015 at 5:16 AM, Alim Akhtar alim.akh...@gmail.com wrote: case MMC_POWER_OFF: - /* Turn clock off before power goes down */ - dw_mci_setup_bus(slot, false); + /* Turn clock off before power goes down; only if powered */

[PATCH] mmc: dw_mmc: Don't send clock off command if power is off

2015-03-20 Thread Doug Anderson
We've already seen that it causes failures if we try to send the "SDMMC_CMD_UPD_CLK" command when power is off to the system. Here's another case where we were doing it: we were sending an SDMMC_CMD_UPD_CLK to set the clock to 0 when the card was already powered off and the clock was already at

[PATCH] mmc: dw_mmc: Don't send clock off command if power is off

2015-03-20 Thread Doug Anderson
We've already seen that it causes failures if we try to send the SDMMC_CMD_UPD_CLK command when power is off to the system. Here's another case where we were doing it: we were sending an SDMMC_CMD_UPD_CLK to set the clock to 0 when the card was already powered off and the clock was already at 0.