Re: [PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-30 Thread addy ke
Hi, Doug, On 2014/10/30 12:49, Doug Anderson wrote: > Addy, > > On Wed, Oct 29, 2014 at 9:41 PM, Doug Anderson wrote: >> You can avoid a lot of "if" tests if you just add a new "sdio->id" > > Whoops, I mean "slot->sdio_id" > To use "slot->sdio_id", I think the subject must be changed. So I

Re: [PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-30 Thread addy ke
Hi, Doug, On 2014/10/30 12:49, Doug Anderson wrote: Addy, On Wed, Oct 29, 2014 at 9:41 PM, Doug Anderson diand...@chromium.org wrote: You can avoid a lot of if tests if you just add a new sdio-id Whoops, I mean slot-sdio_id To use slot-sdio_id, I think the subject must be changed. So I

Re: [PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-29 Thread Doug Anderson
Addy, On Wed, Oct 29, 2014 at 9:41 PM, Doug Anderson wrote: > You can avoid a lot of "if" tests if you just add a new "sdio->id" Whoops, I mean "slot->sdio_id" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-29 Thread Doug Anderson
Addy, On Wed, Oct 29, 2014 at 7:21 PM, Addy Ke wrote: > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -778,6 +778,12 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, > bool force_clkinit) > u32 div; > u32 clk_en_a; > u32 sdmmc_cmd_bits =

Re: [PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-29 Thread Jaehoon Chung
Hi, Addy. On 10/30/2014 11:21 AM, Addy Ke wrote: > This patch add a quirk: DW_MCI_QUIRK_SDIO_INT_24BIT. > > The bit of sdio interrupt is 16 in designware implementation, but > is 24 in RK3288. To support RK3288 mmc controller, we need add > a quirk for it. > > Signed-off-by: Addy Ke > --- >

[PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-29 Thread Addy Ke
This patch add a quirk: DW_MCI_QUIRK_SDIO_INT_24BIT. The bit of sdio interrupt is 16 in designware implementation, but is 24 in RK3288. To support RK3288 mmc controller, we need add a quirk for it. Signed-off-by: Addy Ke --- drivers/mmc/host/dw_mmc.c | 32 +++-

[PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-29 Thread Addy Ke
This patch add a quirk: DW_MCI_QUIRK_SDIO_INT_24BIT. The bit of sdio interrupt is 16 in designware implementation, but is 24 in RK3288. To support RK3288 mmc controller, we need add a quirk for it. Signed-off-by: Addy Ke addy...@rock-chips.com --- drivers/mmc/host/dw_mmc.c | 32

Re: [PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-29 Thread Jaehoon Chung
Hi, Addy. On 10/30/2014 11:21 AM, Addy Ke wrote: This patch add a quirk: DW_MCI_QUIRK_SDIO_INT_24BIT. The bit of sdio interrupt is 16 in designware implementation, but is 24 in RK3288. To support RK3288 mmc controller, we need add a quirk for it. Signed-off-by: Addy Ke

Re: [PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-29 Thread Doug Anderson
Addy, On Wed, Oct 29, 2014 at 7:21 PM, Addy Ke addy...@rock-chips.com wrote: --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -778,6 +778,12 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit) u32 div; u32 clk_en_a; u32

Re: [PATCH] mmc: dw_mmc: add a quirk for the defferent bit of sdio interrupt

2014-10-29 Thread Doug Anderson
Addy, On Wed, Oct 29, 2014 at 9:41 PM, Doug Anderson diand...@chromium.org wrote: You can avoid a lot of if tests if you just add a new sdio-id Whoops, I mean slot-sdio_id -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to