Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-23 Thread Adrian Hunter
On 23/09/2014 12:20 p.m., Ulf Hansson wrote: On 22 September 2014 12:09, Roger Tseng wrote: On Thu, 2014-09-18 at 23:14 +0200, Ulf Hansson wrote: [...] In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE. if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-23 Thread Ulf Hansson
On 22 September 2014 12:09, Roger Tseng wrote: > On Thu, 2014-09-18 at 23:14 +0200, Ulf Hansson wrote: >> [...] >> >> >> >> >> In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE. >> >> >> >> > >> >> > if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at >> >> > start, >>

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-23 Thread Ulf Hansson
On 22 September 2014 12:09, Roger Tseng rogera...@realtek.com wrote: On Thu, 2014-09-18 at 23:14 +0200, Ulf Hansson wrote: [...] In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE. if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at start, then it

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-23 Thread Adrian Hunter
On 23/09/2014 12:20 p.m., Ulf Hansson wrote: On 22 September 2014 12:09, Roger Tseng rogera...@realtek.com wrote: On Thu, 2014-09-18 at 23:14 +0200, Ulf Hansson wrote: [...] In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE. if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-22 Thread Roger Tseng
On Thu, 2014-09-18 at 23:14 +0200, Ulf Hansson wrote: > [...] > > >> > >> In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE. > >> > >> > > >> > if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at > >> > start, > >> > then it will check ios.power_mode, but the state is

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-22 Thread Roger Tseng
On Thu, 2014-09-18 at 23:14 +0200, Ulf Hansson wrote: [...] In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE. if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at start, then it will check ios.power_mode, but the state is MMC_POWER_OFF and just

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-18 Thread Ulf Hansson
[...] >> >> In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE. >> >> > >> > if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at start, >> > then it will check ios.power_mode, but the state is MMC_POWER_OFF and just >> > return. >> >> Uhh, that's right! So, I wonder why

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-18 Thread Roger Tseng
On Wed, 2014-09-17 at 21:29 +0200, Ulf Hansson wrote: > On 17 September 2014 11:11, micky wrote: > > On 09/17/2014 02:01 AM, Ulf Hansson wrote: > >> > >> On 12 September 2014 03:39, wrote: > >>> > >>> From: Roger Tseng > >>> > >>> Some platform have both UEFI driver and MFD/mmc driver, if

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-18 Thread Ulf Hansson
[...] In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE. if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at start, then it will check ios.power_mode, but the state is MMC_POWER_OFF and just return. Uhh, that's right! So, I wonder why we invokes

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-18 Thread Roger Tseng
On Wed, 2014-09-17 at 21:29 +0200, Ulf Hansson wrote: On 17 September 2014 11:11, micky micky_ch...@realsil.com.cn wrote: On 09/17/2014 02:01 AM, Ulf Hansson wrote: On 12 September 2014 03:39, micky_ch...@realsil.com.cn wrote: From: Roger Tseng rogera...@realtek.com Some platform

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread Ulf Hansson
On 17 September 2014 11:11, micky wrote: > On 09/17/2014 02:01 AM, Ulf Hansson wrote: >> >> On 12 September 2014 03:39, wrote: >>> >>> From: Roger Tseng >>> >>> Some platform have both UEFI driver and MFD/mmc driver, if entering >>> linux while card in the slot, the card power is already on,

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread micky
On 09/17/2014 02:01 AM, Ulf Hansson wrote: On 12 September 2014 03:39, wrote: From: Roger Tseng Some platform have both UEFI driver and MFD/mmc driver, if entering linux while card in the slot, the card power is already on, and rtsx-mmc driver have no chance to make card power off. This

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread micky
On 09/17/2014 02:01 AM, Ulf Hansson wrote: On 12 September 2014 03:39, micky_ch...@realsil.com.cn wrote: From: Roger Tseng rogera...@realtek.com Some platform have both UEFI driver and MFD/mmc driver, if entering linux while card in the slot, the card power is already on, and rtsx-mmc driver

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread Ulf Hansson
On 17 September 2014 11:11, micky micky_ch...@realsil.com.cn wrote: On 09/17/2014 02:01 AM, Ulf Hansson wrote: On 12 September 2014 03:39, micky_ch...@realsil.com.cn wrote: From: Roger Tseng rogera...@realtek.com Some platform have both UEFI driver and MFD/mmc driver, if entering linux

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-16 Thread Ulf Hansson
On 12 September 2014 03:39, wrote: > From: Roger Tseng > > Some platform have both UEFI driver and MFD/mmc driver, if entering > linux while card in the slot, the card power is already on, and rtsx-mmc > driver have no chance to make card power off. This will lead UHSI card > failed to enter

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-16 Thread Ulf Hansson
On 12 September 2014 03:39, micky_ch...@realsil.com.cn wrote: From: Roger Tseng rogera...@realtek.com Some platform have both UEFI driver and MFD/mmc driver, if entering linux while card in the slot, the card power is already on, and rtsx-mmc driver have no chance to make card power off.

[PATCH] mmc: rtsx: add card power off during probe

2014-09-11 Thread micky_ching
From: Roger Tseng Some platform have both UEFI driver and MFD/mmc driver, if entering linux while card in the slot, the card power is already on, and rtsx-mmc driver have no chance to make card power off. This will lead UHSI card failed to enter UHSI mode. It is hard to control the UEFI driver

[PATCH] mmc: rtsx: add card power off during probe

2014-09-11 Thread micky_ching
From: Roger Tseng rogera...@realtek.com Some platform have both UEFI driver and MFD/mmc driver, if entering linux while card in the slot, the card power is already on, and rtsx-mmc driver have no chance to make card power off. This will lead UHSI card failed to enter UHSI mode. It is hard to