Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ludovic Desroches
On Fri, Feb 12, 2016 at 12:01:39PM +0100, Ulf Hansson wrote: > >> > >> According to the below commit, SDHCI_QUIRK_BROKEN_CARD_DETECTION was > >> invented because of unreliable card detection mechanism inside the > >> sdhci controller. > >> Therefore it required polling to be used, but also to make

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ulf Hansson
>> >> According to the below commit, SDHCI_QUIRK_BROKEN_CARD_DETECTION was >> invented because of unreliable card detection mechanism inside the >> sdhci controller. >> Therefore it required polling to be used, but also to make ->get_cd() >> to always return 1 in these cases. >> >> Although, as I

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ludovic Desroches
On Thu, Feb 11, 2016 at 04:10:54PM +0100, Ulf Hansson wrote: > On 11 February 2016 at 14:48, Ludovic Desroches > wrote: > > Add quirk broken card detection to enable card detection polling. It is > > a short term solution until reworking PM stuff. > > > > If the card detect signal is connected to

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ludovic Desroches
On Thu, Feb 11, 2016 at 04:10:54PM +0100, Ulf Hansson wrote: > On 11 February 2016 at 14:48, Ludovic Desroches > wrote: > > Add quirk broken card detection to enable card detection polling. It is > > a short term solution until reworking PM stuff. > > > > If the card

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ulf Hansson
>> >> According to the below commit, SDHCI_QUIRK_BROKEN_CARD_DETECTION was >> invented because of unreliable card detection mechanism inside the >> sdhci controller. >> Therefore it required polling to be used, but also to make ->get_cd() >> to always return 1 in these cases. >> >> Although, as I

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ludovic Desroches
On Fri, Feb 12, 2016 at 12:01:39PM +0100, Ulf Hansson wrote: > >> > >> According to the below commit, SDHCI_QUIRK_BROKEN_CARD_DETECTION was > >> invented because of unreliable card detection mechanism inside the > >> sdhci controller. > >> Therefore it required polling to be used, but also to make

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-11 Thread Ulf Hansson
On 11 February 2016 at 14:48, Ludovic Desroches wrote: > Add quirk broken card detection to enable card detection polling. It is > a short term solution until reworking PM stuff. > > If the card detect signal is connected to the sdhci controller and not a > gpio, when runtime PM suspend happens,

[PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-11 Thread Ludovic Desroches
Add quirk broken card detection to enable card detection polling. It is a short term solution until reworking PM stuff. If the card detect signal is connected to the sdhci controller and not a gpio, when runtime PM suspend happens, we have no way to wake up on a card detect event since these irqs

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-11 Thread Ulf Hansson
On 11 February 2016 at 14:48, Ludovic Desroches wrote: > Add quirk broken card detection to enable card detection polling. It is > a short term solution until reworking PM stuff. > > If the card detect signal is connected to the sdhci controller and not a > gpio, when

[PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-11 Thread Ludovic Desroches
Add quirk broken card detection to enable card detection polling. It is a short term solution until reworking PM stuff. If the card detect signal is connected to the sdhci controller and not a gpio, when runtime PM suspend happens, we have no way to wake up on a card detect event since these irqs