Re: [PATCH] mmc: sdhi: fill in actual_clock

2019-08-29 Thread Wolfram Sang
> It would be possible to call clk_get_rate() unconditionally but > there's usually no need, thus the ternary. Are you in favor of that > though? I like Geert's suggestion. Even if it is "usually" not needed, I think it is better to be always proper. This is not a hot code path. signature.asc

Re: [PATCH] mmc: sdhi: fill in actual_clock

2019-08-29 Thread Tamás Szűcs
Hi Geert, It would be possible to call clk_get_rate() unconditionally but there's usually no need, thus the ternary. Are you in favor of that though? It turns out I need to send a followup to fix some glitches. Please stay tuned. Kind regards, Tamas Tamás Szűcs tsz...@protonmail.ch ‐‐‐

Re: [PATCH] mmc: sdhi: fill in actual_clock

2019-08-29 Thread Geert Uytterhoeven
Hi Tamás, On Wed, Aug 28, 2019 at 9:02 PM Tamás Szűcs wrote: > Save set clock in mmc_host actual_clock enabling exporting it via debugfs. > This will indicate the precise SD clock in I/O settings rather than only the > sometimes misleading requested clock. > > Signed-off-by: Tamás Szűcs Thanks

[PATCH] mmc: sdhi: fill in actual_clock

2019-08-28 Thread Tamás Szűcs
Save set clock in mmc_host actual_clock enabling exporting it via debugfs. This will indicate the precise SD clock in I/O settings rather than only the sometimes misleading requested clock. Signed-off-by: Tamás Szűcs --- drivers/mmc/host/renesas_sdhi_core.c | 8 +--- 1 file changed, 5