Re: [PATCH] mmc: tegra: Add and use tegra_sdhci_get_max_clock()

2018-07-16 Thread Jon Hunter
On 13/07/18 16:39, Aapo Vienamo wrote: ... >>> that it returns the current clock rate of the host instead of the >>> maximum one, which can lead to unnecessarily small clock rates. >>> >>> This differs from the previous implementation of >>> tegra_sdhci_get_max_clock() in that it doesn't divide

Re: [PATCH] mmc: tegra: Add and use tegra_sdhci_get_max_clock()

2018-07-16 Thread Ulf Hansson
+Stefan On 13 July 2018 at 15:17, Aapo Vienamo wrote: > Implement and use tegra_sdhci_get_max_clock() which returns the true > maximum host clock rate. The issue with tegra_sdhci_get_max_clock() is > that it returns the current clock rate of the host instead of the > maximum one, which can lead t

Re: [PATCH] mmc: tegra: Add and use tegra_sdhci_get_max_clock()

2018-07-13 Thread Marcel Ziswiler
On Fri, 2018-07-13 at 16:17 +0300, Aapo Vienamo wrote: > Implement and use tegra_sdhci_get_max_clock() which returns the true > maximum host clock rate. The issue with tegra_sdhci_get_max_clock() > is > that it returns the current clock rate of the host instead of the > maximum one, which can lead

Re: [PATCH] mmc: tegra: Add and use tegra_sdhci_get_max_clock()

2018-07-13 Thread Aapo Vienamo
On Fri, 13 Jul 2018 15:01:21 +0100 Jon Hunter wrote: > On 13/07/18 14:17, Aapo Vienamo wrote: > > Implement and use tegra_sdhci_get_max_clock() which returns the true > > maximum host clock rate. The issue with tegra_sdhci_get_max_clock() is > > Don't you mean sdhci_pltfm_clk_get_max_clock abo

Re: [PATCH] mmc: tegra: Add and use tegra_sdhci_get_max_clock()

2018-07-13 Thread Jon Hunter
On 13/07/18 14:17, Aapo Vienamo wrote: > Implement and use tegra_sdhci_get_max_clock() which returns the true > maximum host clock rate. The issue with tegra_sdhci_get_max_clock() is Don't you mean sdhci_pltfm_clk_get_max_clock above? Does this function need fixing then? Or at least should there

[PATCH] mmc: tegra: Add and use tegra_sdhci_get_max_clock()

2018-07-13 Thread Aapo Vienamo
Implement and use tegra_sdhci_get_max_clock() which returns the true maximum host clock rate. The issue with tegra_sdhci_get_max_clock() is that it returns the current clock rate of the host instead of the maximum one, which can lead to unnecessarily small clock rates. This differs from the previo