Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-05 Thread Josh Poimboeuf
On Tue, Jun 05, 2018 at 10:42:23AM +0200, Jessica Yu wrote: > Livepatch modules are special in that we preserve their entire symbol > tables in order to be able to apply relocations after module load. The > unwanted side effect of this is that undefined (SHN_UNDEF) symbols of > livepatch modules

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-05 Thread Josh Poimboeuf
On Tue, Jun 05, 2018 at 10:42:23AM +0200, Jessica Yu wrote: > Livepatch modules are special in that we preserve their entire symbol > tables in order to be able to apply relocations after module load. The > unwanted side effect of this is that undefined (SHN_UNDEF) symbols of > livepatch modules

[PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-05 Thread Jessica Yu
Livepatch modules are special in that we preserve their entire symbol tables in order to be able to apply relocations after module load. The unwanted side effect of this is that undefined (SHN_UNDEF) symbols of livepatch modules are accessible via the kallsyms api and this can confuse symbol

[PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-05 Thread Jessica Yu
Livepatch modules are special in that we preserve their entire symbol tables in order to be able to apply relocations after module load. The unwanted side effect of this is that undefined (SHN_UNDEF) symbols of livepatch modules are accessible via the kallsyms api and this can confuse symbol

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-05 Thread Jessica Yu
+++ Josh Poimboeuf [04/06/18 18:02 -0500]: On Mon, Jun 04, 2018 at 05:56:05PM -0500, Josh Poimboeuf wrote: On Mon, Jun 04, 2018 at 09:54:12AM -0500, Josh Poimboeuf wrote: > On Mon, Jun 04, 2018 at 04:05:11PM +0200, Jessica Yu wrote: > > +++ Josh Poimboeuf [04/06/18 08:16 -0500]: > > > On Mon,

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-05 Thread Jessica Yu
+++ Josh Poimboeuf [04/06/18 18:02 -0500]: On Mon, Jun 04, 2018 at 05:56:05PM -0500, Josh Poimboeuf wrote: On Mon, Jun 04, 2018 at 09:54:12AM -0500, Josh Poimboeuf wrote: > On Mon, Jun 04, 2018 at 04:05:11PM +0200, Jessica Yu wrote: > > +++ Josh Poimboeuf [04/06/18 08:16 -0500]: > > > On Mon,

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 05:56:05PM -0500, Josh Poimboeuf wrote: > On Mon, Jun 04, 2018 at 09:54:12AM -0500, Josh Poimboeuf wrote: > > On Mon, Jun 04, 2018 at 04:05:11PM +0200, Jessica Yu wrote: > > > +++ Josh Poimboeuf [04/06/18 08:16 -0500]: > > > > On Mon, Jun 04, 2018 at 03:01:31PM +0200,

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 05:56:05PM -0500, Josh Poimboeuf wrote: > On Mon, Jun 04, 2018 at 09:54:12AM -0500, Josh Poimboeuf wrote: > > On Mon, Jun 04, 2018 at 04:05:11PM +0200, Jessica Yu wrote: > > > +++ Josh Poimboeuf [04/06/18 08:16 -0500]: > > > > On Mon, Jun 04, 2018 at 03:01:31PM +0200,

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 09:54:12AM -0500, Josh Poimboeuf wrote: > On Mon, Jun 04, 2018 at 04:05:11PM +0200, Jessica Yu wrote: > > +++ Josh Poimboeuf [04/06/18 08:16 -0500]: > > > On Mon, Jun 04, 2018 at 03:01:31PM +0200, Jessica Yu wrote: > > > > +++ Jessica Yu [04/06/18 11:54 +0200]: > > > > >

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 09:54:12AM -0500, Josh Poimboeuf wrote: > On Mon, Jun 04, 2018 at 04:05:11PM +0200, Jessica Yu wrote: > > +++ Josh Poimboeuf [04/06/18 08:16 -0500]: > > > On Mon, Jun 04, 2018 at 03:01:31PM +0200, Jessica Yu wrote: > > > > +++ Jessica Yu [04/06/18 11:54 +0200]: > > > > >

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 04:05:11PM +0200, Jessica Yu wrote: > +++ Josh Poimboeuf [04/06/18 08:16 -0500]: > > On Mon, Jun 04, 2018 at 03:01:31PM +0200, Jessica Yu wrote: > > > +++ Jessica Yu [04/06/18 11:54 +0200]: > > > > +++ Jessica Yu [04/06/18 10:05 +0200]: > > > > > +++ Josh Poimboeuf

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 04:05:11PM +0200, Jessica Yu wrote: > +++ Josh Poimboeuf [04/06/18 08:16 -0500]: > > On Mon, Jun 04, 2018 at 03:01:31PM +0200, Jessica Yu wrote: > > > +++ Jessica Yu [04/06/18 11:54 +0200]: > > > > +++ Jessica Yu [04/06/18 10:05 +0200]: > > > > > +++ Josh Poimboeuf

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Jessica Yu
+++ Josh Poimboeuf [04/06/18 08:16 -0500]: On Mon, Jun 04, 2018 at 03:01:31PM +0200, Jessica Yu wrote: +++ Jessica Yu [04/06/18 11:54 +0200]: > +++ Jessica Yu [04/06/18 10:05 +0200]: > > +++ Josh Poimboeuf [02/06/18 12:32 -0500]: > > > Hi Jessica, > > > > > > I found a bug: > > > > > >

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Jessica Yu
+++ Josh Poimboeuf [04/06/18 08:16 -0500]: On Mon, Jun 04, 2018 at 03:01:31PM +0200, Jessica Yu wrote: +++ Jessica Yu [04/06/18 11:54 +0200]: > +++ Jessica Yu [04/06/18 10:05 +0200]: > > +++ Josh Poimboeuf [02/06/18 12:32 -0500]: > > > Hi Jessica, > > > > > > I found a bug: > > > > > >

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 03:01:31PM +0200, Jessica Yu wrote: > +++ Jessica Yu [04/06/18 11:54 +0200]: > > +++ Jessica Yu [04/06/18 10:05 +0200]: > > > +++ Josh Poimboeuf [02/06/18 12:32 -0500]: > > > > Hi Jessica, > > > > > > > > I found a bug: > > > > > > > > [root@f25 ~]# modprobe

Re: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 03:01:31PM +0200, Jessica Yu wrote: > +++ Jessica Yu [04/06/18 11:54 +0200]: > > +++ Jessica Yu [04/06/18 10:05 +0200]: > > > +++ Josh Poimboeuf [02/06/18 12:32 -0500]: > > > > Hi Jessica, > > > > > > > > I found a bug: > > > > > > > > [root@f25 ~]# modprobe

[PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Jessica Yu
9cfd14675206adf55a85e5f5322b36ea89a523e4 Mon Sep 17 00:00:00 2001 From: Jessica Yu Date: Mon, 4 Jun 2018 14:35:56 +0200 Subject: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api --- kernel/module.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c

[PATCH] module: exclude SHN_UNDEF symbols from kallsyms api

2018-06-04 Thread Jessica Yu
9cfd14675206adf55a85e5f5322b36ea89a523e4 Mon Sep 17 00:00:00 2001 From: Jessica Yu Date: Mon, 4 Jun 2018 14:35:56 +0200 Subject: [PATCH] module: exclude SHN_UNDEF symbols from kallsyms api --- kernel/module.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c