Re: [PATCH] more work_struct mess

2006-12-17 Thread Benjamin Herrenschmidt
On Fri, 2006-12-08 at 09:16 +, Al Viro wrote: > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- Please merge, right now, pmac32_defconfig is busted. I'm tempted to mark dmasound_pmac for removal soon too ... Ben. > --- > diff --git

Re: [PATCH] more work_struct mess

2006-12-17 Thread Benjamin Herrenschmidt
On Fri, 2006-12-08 at 09:16 +, Al Viro wrote: Signed-off-by: Al Viro [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- Please merge, right now, pmac32_defconfig is busted. I'm tempted to mark dmasound_pmac for removal soon too ... Ben. --- diff --git

Re: [PATCH] more work_struct mess

2006-12-09 Thread Olaf Hering
On Sat, Dec 09, Al Viro wrote: > On Sat, Dec 09, 2006 at 12:25:10PM +0100, Olaf Hering wrote: > > This is not enough to get it going: > > > > error: 'INIT_WORK' undeclared (first use in this function) > > .config? Its a gcc bug. It doesnt like the number of arguments for INIT_WORK, then it

Re: [PATCH] more work_struct mess

2006-12-09 Thread Al Viro
On Sat, Dec 09, 2006 at 12:25:10PM +0100, Olaf Hering wrote: > This is not enough to get it going: > > error: 'INIT_WORK' undeclared (first use in this function) .config? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] more work_struct mess

2006-12-09 Thread Olaf Hering
On Fri, Dec 08, Al Viro wrote: > +++ b/sound/oss/dmasound/tas3001c.c > @@ -823,7 +823,7 @@ tas3001c_init(struct i2c_client *client) > tas3001c_write_biquad_shadow(self, i, j, > _eq_unity); > > - INIT_WORK(_change,

Re: [PATCH] more work_struct mess

2006-12-09 Thread Olaf Hering
On Fri, Dec 08, Al Viro wrote: +++ b/sound/oss/dmasound/tas3001c.c @@ -823,7 +823,7 @@ tas3001c_init(struct i2c_client *client) tas3001c_write_biquad_shadow(self, i, j, tas3001c_eq_unity); - INIT_WORK(device_change,

Re: [PATCH] more work_struct mess

2006-12-09 Thread Al Viro
On Sat, Dec 09, 2006 at 12:25:10PM +0100, Olaf Hering wrote: This is not enough to get it going: error: 'INIT_WORK' undeclared (first use in this function) .config? - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] more work_struct mess

2006-12-09 Thread Olaf Hering
On Sat, Dec 09, Al Viro wrote: On Sat, Dec 09, 2006 at 12:25:10PM +0100, Olaf Hering wrote: This is not enough to get it going: error: 'INIT_WORK' undeclared (first use in this function) .config? Its a gcc bug. It doesnt like the number of arguments for INIT_WORK, then it appearently

[PATCH] more work_struct mess

2006-12-08 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/sound/oss/dmasound/tas3001c.c b/sound/oss/dmasound/tas3001c.c index f227c9f..2f21a3c 100644 --- a/sound/oss/dmasound/tas3001c.c +++ b/sound/oss/dmasound/tas3001c.c @@ -50,6 +50,7 @@ struct tas3001c_data_t { int output_id;

[PATCH] more work_struct mess

2006-12-08 Thread Al Viro
Signed-off-by: Al Viro [EMAIL PROTECTED] --- diff --git a/sound/oss/dmasound/tas3001c.c b/sound/oss/dmasound/tas3001c.c index f227c9f..2f21a3c 100644 --- a/sound/oss/dmasound/tas3001c.c +++ b/sound/oss/dmasound/tas3001c.c @@ -50,6 +50,7 @@ struct tas3001c_data_t { int output_id;