Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 17:47:20 +0200 Matthieu Baerts wrote: > On 19/10/2020 13:32, Geert Uytterhoeven wrote: > > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the > > user may not want to enable. Fix this by making the test depend on > > MPTCP instead. > > Reviewed-by:

Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-20 Thread Matthieu Baerts
Hi Geert, On 20/10/2020 09:40, Geert Uytterhoeven wrote: On Mon, Oct 19, 2020 at 10:38 PM Geert Uytterhoeven wrote: On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts wrote: On 19/10/2020 13:32, Geert Uytterhoeven wrote: MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the

Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-20 Thread Geert Uytterhoeven
On Mon, Oct 19, 2020 at 10:38 PM Geert Uytterhoeven wrote: > On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts > wrote: > > On 19/10/2020 13:32, Geert Uytterhoeven wrote: > > > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the > > > user may not want to enable. Fix this by

Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-19 Thread Geert Uytterhoeven
Hi Matthieu, On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts wrote: > On 19/10/2020 13:32, Geert Uytterhoeven wrote: > > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the > > user may not want to enable. Fix this by making the test depend on > > MPTCP instead. > > I think

Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-19 Thread Matthieu Baerts
Hi Geert, Thank you for the patch! On 19/10/2020 13:32, Geert Uytterhoeven wrote: MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead. I think the initial intension was to select MPTCP to

[PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-19 Thread Geert Uytterhoeven
MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead. Fixes: a00a582203dbc43e ("mptcp: move crypto test to KUNIT") Signed-off-by: Geert Uytterhoeven --- net/mptcp/Kconfig | 4 +--- 1 file