On Mon, 13 May 2013 10:58:52 +0300, Artem Bityutskiy wrote:
>
> I think the patch is useful so I am taking it to my l2 tree. I do not
> want to annoy you at all, I just think that it is not fair to drop a
> tiny, but still useful cleanup just because of a bitten to death
> indentation question.
On Fri, 2013-04-19 at 10:59 -0700, Joe Perches wrote:
> Use a more current logging style.
>
> Convert homegrown ERROR/INFO macros to pr_.
> Convert homegrown parse_err macros to pr_err and
> expand hidden flow control.
>
> Signed-off-by: Joe Perches
Pushed to l2-mtd.git, thanks!
--
Best
On Tue, 2013-04-23 at 12:51 -0400, Jörn Engel wrote:
> In that case: NAK.
>
> Because you personally dislike something isn't
> enough of a reason for me to take your patch nor
> enough of a reason for me to add a special
> exception to my standards for your preferences.
>
> Cuts both way, it
On Tue, 2013-04-23 at 12:51 -0400, Jörn Engel wrote:
In that case: NAK.
Because you personally dislike something isn't
enough of a reason for me to take your patch nor
enough of a reason for me to add a special
exception to my standards for your preferences.
Cuts both way, it seems.
Hi
On Fri, 2013-04-19 at 10:59 -0700, Joe Perches wrote:
Use a more current logging style.
Convert homegrown ERROR/INFO macros to pr_level.
Convert homegrown parse_err macros to pr_err and
expand hidden flow control.
Signed-off-by: Joe Perches j...@perches.com
Pushed to l2-mtd.git, thanks!
On Mon, 13 May 2013 10:58:52 +0300, Artem Bityutskiy wrote:
I think the patch is useful so I am taking it to my l2 tree. I do not
want to annoy you at all, I just think that it is not fair to drop a
tiny, but still useful cleanup just because of a bitten to death
indentation question.
Fair
On Tue, 2013-04-23 at 12:51 -0400, Jörn Engel wrote:
> NAK.
No worries.
It'd be good if you fixed the macros with hidden
flow control.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Tue, 23 April 2013 10:59:54 -0700, Joe Perches wrote:
> On Mon, 2013-04-22 at 10:31 -0400, Jörn Engel wrote:
> > On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
> > > On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> > > > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
>
On Mon, 2013-04-22 at 10:31 -0400, Jörn Engel wrote:
> On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
> > On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> > > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> > > > }
> > > > list_add(>list, _device_list);
>
On Mon, 2013-04-22 at 10:31 -0400, Jörn Engel wrote:
On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
}
list_add(dev-list, blkmtd_device_list);
-
On Tue, 23 April 2013 10:59:54 -0700, Joe Perches wrote:
On Mon, 2013-04-22 at 10:31 -0400, Jörn Engel wrote:
On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
On Tue, 2013-04-23 at 12:51 -0400, Jörn Engel wrote:
NAK.
No worries.
It'd be good if you fixed the macros with hidden
flow control.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
> On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> > > }
> > > list_add(>list, _device_list);
> > > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
> > > -
On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
}
list_add(dev-list, blkmtd_device_list);
- INFO(mtd%d: [%s] erase_size = %dKiB [%d], dev-mtd.index,
-
On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> > }
> > list_add(>list, _device_list);
> > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
> > - dev->mtd.name + strlen("block2mtd: "),
> > -
On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> }
> list_add(>list, _device_list);
> - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
> - dev->mtd.name + strlen("block2mtd: "),
> - dev->mtd.erasesize >> 10,
Use a more current logging style.
Convert homegrown ERROR/INFO macros to pr_.
Convert homegrown parse_err macros to pr_err and
expand hidden flow control.
Signed-off-by: Joe Perches
---
drivers/mtd/devices/block2mtd.c | 58 ++---
1 file changed, 31
Use a more current logging style.
Convert homegrown ERROR/INFO macros to pr_level.
Convert homegrown parse_err macros to pr_err and
expand hidden flow control.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/mtd/devices/block2mtd.c | 58 ++---
1 file
On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
}
list_add(dev-list, blkmtd_device_list);
- INFO(mtd%d: [%s] erase_size = %dKiB [%d], dev-mtd.index,
- dev-mtd.name + strlen(block2mtd: ),
- dev-mtd.erasesize 10,
On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
}
list_add(dev-list, blkmtd_device_list);
- INFO(mtd%d: [%s] erase_size = %dKiB [%d], dev-mtd.index,
- dev-mtd.name + strlen(block2mtd: ),
-
20 matches
Mail list logo
