Re: [PATCH] mtd: Replace if and BUG with BUG_ON

2016-07-09 Thread Brian Norris
Hi, On Tue, May 31, 2016 at 07:41:23AM +0200, Julia Lawall wrote: > On Mon, 30 May 2016, Ezequiel Garcia wrote: > > On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote: > > > Replace if condition and BUG() with a BUG_ON having the conditional > > > expression of the if

Re: [PATCH] mtd: Replace if and BUG with BUG_ON

2016-07-09 Thread Brian Norris
Hi, On Tue, May 31, 2016 at 07:41:23AM +0200, Julia Lawall wrote: > On Mon, 30 May 2016, Ezequiel Garcia wrote: > > On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote: > > > Replace if condition and BUG() with a BUG_ON having the conditional > > > expression of the if statement as argument. [...]

Re: [PATCH] mtd: Replace if and BUG with BUG_ON

2016-05-30 Thread Julia Lawall
On Mon, 30 May 2016, Ezequiel Garcia wrote: > Hi Amitoj, > > Thanks for your patch. > > On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote: > > Replace if condition and BUG() with a BUG_ON having the conditional > > expression of the if statement as argument. > > > > We

Re: [PATCH] mtd: Replace if and BUG with BUG_ON

2016-05-30 Thread Julia Lawall
On Mon, 30 May 2016, Ezequiel Garcia wrote: > Hi Amitoj, > > Thanks for your patch. > > On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote: > > Replace if condition and BUG() with a BUG_ON having the conditional > > expression of the if statement as argument. > > > > We usually want commit

Re: [PATCH] mtd: Replace if and BUG with BUG_ON

2016-05-30 Thread Ezequiel Garcia
Hi Amitoj, Thanks for your patch. On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote: > Replace if condition and BUG() with a BUG_ON having the conditional > expression of the if statement as argument. > We usually want commit messages that tell us *why* you are doing the

Re: [PATCH] mtd: Replace if and BUG with BUG_ON

2016-05-30 Thread Ezequiel Garcia
Hi Amitoj, Thanks for your patch. On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote: > Replace if condition and BUG() with a BUG_ON having the conditional > expression of the if statement as argument. > We usually want commit messages that tell us *why* you are doing the change: what are you

[PATCH] mtd: Replace if and BUG with BUG_ON

2016-05-28 Thread Amitoj Kaur Chawla
Replace if condition and BUG() with a BUG_ON having the conditional expression of the if statement as argument. The Coccinelle semantic patch used to make this change is as follows: @@ expression E,f; @@ ( if (<+... f(...) ...+>) { BUG(); } | - if (E) { BUG(); } + BUG_ON(E); ) Signed-off-by:

[PATCH] mtd: Replace if and BUG with BUG_ON

2016-05-28 Thread Amitoj Kaur Chawla
Replace if condition and BUG() with a BUG_ON having the conditional expression of the if statement as argument. The Coccinelle semantic patch used to make this change is as follows: @@ expression E,f; @@ ( if (<+... f(...) ...+>) { BUG(); } | - if (E) { BUG(); } + BUG_ON(E); ) Signed-off-by: