Hi,
On Tue, May 31, 2016 at 07:41:23AM +0200, Julia Lawall wrote:
> On Mon, 30 May 2016, Ezequiel Garcia wrote:
> > On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote:
> > > Replace if condition and BUG() with a BUG_ON having the conditional
> > > expression of the if
Hi,
On Tue, May 31, 2016 at 07:41:23AM +0200, Julia Lawall wrote:
> On Mon, 30 May 2016, Ezequiel Garcia wrote:
> > On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote:
> > > Replace if condition and BUG() with a BUG_ON having the conditional
> > > expression of the if statement as argument.
[...]
On Mon, 30 May 2016, Ezequiel Garcia wrote:
> Hi Amitoj,
>
> Thanks for your patch.
>
> On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote:
> > Replace if condition and BUG() with a BUG_ON having the conditional
> > expression of the if statement as argument.
> >
>
> We
On Mon, 30 May 2016, Ezequiel Garcia wrote:
> Hi Amitoj,
>
> Thanks for your patch.
>
> On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote:
> > Replace if condition and BUG() with a BUG_ON having the conditional
> > expression of the if statement as argument.
> >
>
> We usually want commit
Hi Amitoj,
Thanks for your patch.
On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote:
> Replace if condition and BUG() with a BUG_ON having the conditional
> expression of the if statement as argument.
>
We usually want commit messages that tell us *why* you are doing the
Hi Amitoj,
Thanks for your patch.
On 28 May 2016 at 13:41, Amitoj Kaur Chawla wrote:
> Replace if condition and BUG() with a BUG_ON having the conditional
> expression of the if statement as argument.
>
We usually want commit messages that tell us *why* you are doing the
change: what are you
Replace if condition and BUG() with a BUG_ON having the conditional
expression of the if statement as argument.
The Coccinelle semantic patch used to make this change is as follows:
@@ expression E,f; @@
(
if (<+... f(...) ...+>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
Signed-off-by:
Replace if condition and BUG() with a BUG_ON having the conditional
expression of the if statement as argument.
The Coccinelle semantic patch used to make this change is as follows:
@@ expression E,f; @@
(
if (<+... f(...) ...+>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
Signed-off-by:
8 matches
Mail list logo