Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-24 Thread Artem Bityutskiy
On Tue, 2012-08-14 at 22:38 -0400, Huang Shijie wrote: > Just as Artem suggested: > > "Both UBI and JFFS2 are able to read verify what they wrote already. > There are also MTD tests which do this verification. So I think there > is no reason to keep this in the NAND layer, let alone wasting RAM

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-24 Thread Artem Bityutskiy
On Tue, 2012-08-14 at 22:38 -0400, Huang Shijie wrote: Just as Artem suggested: Both UBI and JFFS2 are able to read verify what they wrote already. There are also MTD tests which do this verification. So I think there is no reason to keep this in the NAND layer, let alone wasting RAM in the

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-16 Thread Marek Vasut
Dear Huang Shijie, > 于 2012年08月15日 20:09, Marek Vasut 写道: > > I'd still prefer for this to be rather fixed. It seems to be able to find > > some obvious mistakes etc. > > could you please point out the mistakes? Usual stuff -- flaws in drivers, misbehavior of the chip etc Best regards, Marek

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-16 Thread Huang Shijie
于 2012年08月15日 20:09, Marek Vasut 写道: I'd still prefer for this to be rather fixed. It seems to be able to find some obvious mistakes etc. could you please point out the mistakes? thanks Huang Shijie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-16 Thread Huang Shijie
于 2012年08月15日 20:09, Marek Vasut 写道: I'd still prefer for this to be rather fixed. It seems to be able to find some obvious mistakes etc. could you please point out the mistakes? thanks Huang Shijie -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-16 Thread Marek Vasut
Dear Huang Shijie, 于 2012年08月15日 20:09, Marek Vasut 写道: I'd still prefer for this to be rather fixed. It seems to be able to find some obvious mistakes etc. could you please point out the mistakes? Usual stuff -- flaws in drivers, misbehavior of the chip etc Best regards, Marek Vasut --

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-15 Thread Marek Vasut
Dear Huang Shijie, > 于 2012年08月15日 15:06, Shmulik Ladkani 写道: > > Hi Huang, > > > > On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijie wrote: > >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > >> index 588e989..0ca7257 100644 > >> --- a/drivers/mtd/nand/Kconfig > >> +++

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-15 Thread Huang Shijie
于 2012年08月15日 15:06, Shmulik Ladkani 写道: Hi Huang, On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijie wrote: diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 588e989..0ca7257 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -22,15 +22,6 @@ menuconfig

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-15 Thread Shmulik Ladkani
Hi Huang, On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijie wrote: > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 588e989..0ca7257 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -22,15 +22,6 @@ menuconfig MTD_NAND > > if MTD_NAND > >

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-15 Thread Shmulik Ladkani
Hi Huang, On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijie shij...@gmail.com wrote: diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 588e989..0ca7257 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -22,15 +22,6 @@ menuconfig MTD_NAND if

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-15 Thread Huang Shijie
于 2012年08月15日 15:06, Shmulik Ladkani 写道: Hi Huang, On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijieshij...@gmail.com wrote: diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 588e989..0ca7257 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -22,15

Re: [PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-15 Thread Marek Vasut
Dear Huang Shijie, 于 2012年08月15日 15:06, Shmulik Ladkani 写道: Hi Huang, On Tue, 14 Aug 2012 22:38:45 -0400 Huang Shijieshij...@gmail.com wrote: diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 588e989..0ca7257 100644 --- a/drivers/mtd/nand/Kconfig +++

[PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-14 Thread Huang Shijie
Just as Artem suggested: "Both UBI and JFFS2 are able to read verify what they wrote already. There are also MTD tests which do this verification. So I think there is no reason to keep this in the NAND layer, let alone wasting RAM in the driver to support this feature." So kill

[PATCH] mtd: kill MTD_NAND_VERIFY_WRITE

2012-08-14 Thread Huang Shijie
Just as Artem suggested: Both UBI and JFFS2 are able to read verify what they wrote already. There are also MTD tests which do this verification. So I think there is no reason to keep this in the NAND layer, let alone wasting RAM in the driver to support this feature. So kill