Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2021-01-04 Thread Ron Minnich
It is likely we're missing something -- I am not fully checked out on the Linux patch process and it's Ian's first patch. Guidance appreciated. On Mon, Jan 4, 2021 at 1:08 AM Miquel Raynal wrote: > > Hello Ian, > > Ian Goegebuer wrote on Wed, 23 Dec 2020 13:56:30 > -0800: > > > On Intel

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2021-01-04 Thread Miquel Raynal
Hello Ian, Ian Goegebuer wrote on Wed, 23 Dec 2020 13:56:30 -0800: > On Intel platforms, the usable SPI area is located several > MiB in from the start, to leave room for descriptors and > the Management Engine binary. Further, not all the remaining > space can be used, as the last 16 MiB

[PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-12-23 Thread Ian Goegebuer
On Intel platforms, the usable SPI area is located several MiB in from the start, to leave room for descriptors and the Management Engine binary. Further, not all the remaining space can be used, as the last 16 MiB contains firmware. To make the SPI usable for mtdblock and other devices, it is

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-12-09 Thread Ron Minnich
Tested-by: Ian Goegebuer On Mon, Dec 7, 2020 at 7:24 AM ron minnich wrote: > > I pinged the person again. Hope to hear today. Sorry for delay. > > On Sun, Dec 6, 2020 at 11:52 PM Sven Eckelmann wrote: > > > > On Friday, 27 November 2020 19:54:30 CET ron minnich wrote: > > > Thanks, Sven, for

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-12-07 Thread ron minnich
I pinged the person again. Hope to hear today. Sorry for delay. On Sun, Dec 6, 2020 at 11:52 PM Sven Eckelmann wrote: > > On Friday, 27 November 2020 19:54:30 CET ron minnich wrote: > > Thanks, Sven, for your patience, I will indeed try to test this next week. > > Any test results? > > Kind

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-12-06 Thread Sven Eckelmann
On Friday, 27 November 2020 19:54:30 CET ron minnich wrote: > Thanks, Sven, for your patience, I will indeed try to test this next week. Any test results? Kind regards, Sven signature.asc Description: This is a digitally signed message part.

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-27 Thread ron minnich
Thanks, Sven, for your patience, I will indeed try to test this next week. On Fri, Nov 27, 2020 at 9:35 AM Sven Eckelmann wrote: > > On Friday, 27 November 2020 18:16:54 CET ron minnich wrote: > > What none of the people involved in the original patch knew was that > > there would be other ':'

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-27 Thread Sven Eckelmann
On Friday, 27 November 2020 18:16:54 CET ron minnich wrote: > What none of the people involved in the original patch knew was that > there would be other ':' in use. Sorry! > > But you are right, my idea is a complete non-starter, don't know what > I was thinking. I am still not sure because I

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-27 Thread ron minnich
Ah ha, I see how different my world is from yours :-) My world is linuxboot, which means the command line is always under control of linux, as linux is my bootloader. So this kind of thing is very easy for me to change. Let me go back to the initial problem and hope I can make better sense. The

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-27 Thread Sven Eckelmann
On Friday, 27 November 2020 17:32:02 CET ron minnich wrote: > I'm a bit worried about how tricky this starts to get. I'm inclined to > go back to an earlier implementation which used a character that had > not yet been used (iirc I used [] around the PCI ID in a very early > version). What if we

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-27 Thread ron minnich
I'm a bit worried about how tricky this starts to get. I'm inclined to go back to an earlier implementation which used a character that had not yet been used (iirc I used [] around the PCI ID in a very early version). What if we used, e.g, a single ! and searched for that? It need not be !; pick a

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-11-21 Thread Sven Eckelmann
On Wednesday, 29 April 2020 18:53:47 CET Ronald G. Minnich wrote: > From: Boris Brezillon > > Looks like some drivers define MTD names with a colon in it, thus > making mtdpart= parsing impossible. Let's fix the parser to gracefully > handle that case: the last ':' in a partition definition

[PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-04-29 Thread Ronald G. Minnich
From: Boris Brezillon Looks like some drivers define MTD names with a colon in it, thus making mtdpart= parsing impossible. Let's fix the parser to gracefully handle that case: the last ':' in a partition definition sequence is considered instead of the first one. Signed-off-by: Boris Brezillon