Re: [PATCH] mtd: sh_flctl: pass FIFO as physical address

2015-12-18 Thread Brian Norris
On Tue, Dec 08, 2015 at 04:38:12PM +0100, Arnd Bergmann wrote: > By convention, the FIFO address we pass using dmaengine_slave_config > is a physical address in the form that is understood by the DMA > engine, as a dma_addr_t, phys_addr_t or resource_size_t. > > The sh_flctl driver however passes

Re: [PATCH] mtd: sh_flctl: pass FIFO as physical address

2015-12-10 Thread Arnd Bergmann
On Thursday 10 December 2015 10:02:06 Geert Uytterhoeven wrote: > > On Thu, Dec 10, 2015 at 3:21 AM, Brian Norris > wrote: > > On Tue, Dec 08, 2015 at 05:30:02PM +0100, Geert Uytterhoeven wrote: > >> On Tue, Dec 8, 2015 at 4:38 PM, Arnd Bergmann wrote: > >> > By convention, the FIFO address we p

Re: [PATCH] mtd: sh_flctl: pass FIFO as physical address

2015-12-10 Thread Geert Uytterhoeven
Hi Brian, On Thu, Dec 10, 2015 at 3:21 AM, Brian Norris wrote: > On Tue, Dec 08, 2015 at 05:30:02PM +0100, Geert Uytterhoeven wrote: >> On Tue, Dec 8, 2015 at 4:38 PM, Arnd Bergmann wrote: >> > By convention, the FIFO address we pass using dmaengine_slave_config >> > is a physical address in the

Re: [PATCH] mtd: sh_flctl: pass FIFO as physical address

2015-12-09 Thread Brian Norris
On Tue, Dec 08, 2015 at 05:30:02PM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 8, 2015 at 4:38 PM, Arnd Bergmann wrote: > > By convention, the FIFO address we pass using dmaengine_slave_config > > is a physical address in the form that is understood by the DMA > > engine, as a dma_addr_t, phys_

Re: [PATCH] mtd: sh_flctl: pass FIFO as physical address

2015-12-08 Thread Geert Uytterhoeven
On Tue, Dec 8, 2015 at 4:38 PM, Arnd Bergmann wrote: > By convention, the FIFO address we pass using dmaengine_slave_config > is a physical address in the form that is understood by the DMA > engine, as a dma_addr_t, phys_addr_t or resource_size_t. > > The sh_flctl driver however passes a virtual

[PATCH] mtd: sh_flctl: pass FIFO as physical address

2015-12-08 Thread Arnd Bergmann
By convention, the FIFO address we pass using dmaengine_slave_config is a physical address in the form that is understood by the DMA engine, as a dma_addr_t, phys_addr_t or resource_size_t. The sh_flctl driver however passes a virtual __iomem address that gets cast to dma_addr_t in the slave drive