Re: [PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-11 Thread Catalin Marinas
On Fri, Jan 11, 2019 at 07:26:09AM +0300, Konstantin Khlebnikov wrote: > On Thu, Jan 10, 2019 at 11:45 PM Cong Wang wrote: > > On Tue, Jan 8, 2019 at 1:30 AM Konstantin Khlebnikov > > wrote: > > > @@ -443,12 +444,14 @@ static struct neigh_hash_table > > > *neigh_hash_alloc(unsigned int shift) >

Re: [PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-10 Thread Konstantin Khlebnikov
On Thu, Jan 10, 2019 at 11:45 PM Cong Wang wrote: > > On Tue, Jan 8, 2019 at 1:30 AM Konstantin Khlebnikov > wrote: > > @@ -443,12 +444,14 @@ static struct neigh_hash_table > > *neigh_hash_alloc(unsigned int shift) > > ret = kmalloc(sizeof(*ret), GFP_ATOMIC); > > if (!ret) > >

Re: [PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-10 Thread Cong Wang
On Tue, Jan 8, 2019 at 1:30 AM Konstantin Khlebnikov wrote: > @@ -443,12 +444,14 @@ static struct neigh_hash_table > *neigh_hash_alloc(unsigned int shift) > ret = kmalloc(sizeof(*ret), GFP_ATOMIC); > if (!ret) > return NULL; > - if (size <= PAGE_SIZE) > +

Re: [PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-10 Thread David Miller
From: Konstantin Khlebnikov Date: Tue, 08 Jan 2019 12:30:00 +0300 > This fixes false-positive kmemleak reports about leaked neighbour entries: ... > Signed-off-by: Konstantin Khlebnikov Applied.

Re: [PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-08 Thread Konstantin Khlebnikov
On 08.01.2019 14:59, Eric Dumazet wrote: On 01/08/2019 01:30 AM, Konstantin Khlebnikov wrote: This fixes false-positive kmemleak reports about leaked neighbour entries: unreferenced object 0x8885c6e4d0a8 (size 1024): size 1024 object : should have been allocated by kzalloc(), right

Re: [PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-08 Thread Eric Dumazet
On 01/08/2019 01:30 AM, Konstantin Khlebnikov wrote: > This fixes false-positive kmemleak reports about leaked neighbour entries: > > unreferenced object 0x8885c6e4d0a8 (size 1024): size 1024 object : should have been allocated by kzalloc(), right ? > comm "softirq", pid 0, jiffies

[PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-08 Thread Konstantin Khlebnikov
This fixes false-positive kmemleak reports about leaked neighbour entries: unreferenced object 0x8885c6e4d0a8 (size 1024): comm "softirq", pid 0, jiffies 4294922664 (age 167640.804s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 20 2c f3 83 ff ff ff ff ,.. 08 c0