Re: [PATCH] net/core/sysctl_net_core.c unused variable

2015-09-06 Thread Nick Warne
On 06/09/15 16:51, Joe Perches wrote: On Sun, 2015-09-06 at 16:36 +0100, Nick Warne wrote: On 06/09/15 16:28, Joe Perches wrote: > On Sun, 2015-09-06 at 16:16 +0100, Nick Warne wrote: >> On 06/09/15 15:52, Joe Perches wrote: >> > On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote: >> >> gcc v

Re: [PATCH] net/core/sysctl_net_core.c unused variable

2015-09-06 Thread Joe Perches
On Sun, 2015-09-06 at 16:36 +0100, Nick Warne wrote: > On 06/09/15 16:28, Joe Perches wrote: > > On Sun, 2015-09-06 at 16:16 +0100, Nick Warne wrote: > >> On 06/09/15 15:52, Joe Perches wrote: > >> > On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote: > >> >> gcc version 4.8.2 (GCC) warns that 'st

Re: [PATCH] net/core/sysctl_net_core.c unused variable

2015-09-06 Thread Nick Warne
On 06/09/15 16:28, Joe Perches wrote: On Sun, 2015-09-06 at 16:16 +0100, Nick Warne wrote: On 06/09/15 15:52, Joe Perches wrote: > On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote: >> gcc version 4.8.2 (GCC) warns that 'static int one = 1;' is declared but >> not used in file net/core/sysctl_

Re: [PATCH] net/core/sysctl_net_core.c unused variable

2015-09-06 Thread Nick Warne
On 06/09/15 15:52, Joe Perches wrote: On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote: gcc version 4.8.2 (GCC) warns that 'static int one = 1;' is declared but not used in file net/core/sysctl_net_core.c. Only when CONFIG_NET isn't set. CONFIG_NET=y Peculiar indeed. Reading the file,

Re: [PATCH] net/core/sysctl_net_core.c unused variable

2015-09-06 Thread Joe Perches
On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote: > gcc version 4.8.2 (GCC) warns that 'static int one = 1;' is declared but > not used in file net/core/sysctl_net_core.c. Only when CONFIG_NET isn't set. > Reading the file, that is > the case. Attached is a patch to remove it. $ git grep -

[PATCH] net/core/sysctl_net_core.c unused variable

2015-09-06 Thread Nick Warne
gcc version 4.8.2 (GCC) warns that 'static int one = 1;' is declared but not used in file net/core/sysctl_net_core.c. Reading the file, that is the case. Attached is a patch to remove it. Signed-off-by: Nick Warne Nick -- Gosh that takes me back... or is it forward? That's the trouble wit