Re: [PATCH] net/mlx5e: always initialize frag->last_in_page

2019-08-01 Thread Tariq Toukan
On 7/31/2019 10:02 PM, Qian Cai wrote: > The commit 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue > memory scheme") introduced an undefined behaviour below due to > "frag->last_in_page" is only initialized in > mlx5e_init_frags_partition() when, > > if (next_frag.offset + frag_info[

[PATCH] net/mlx5e: always initialize frag->last_in_page

2019-07-31 Thread Qian Cai
The commit 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory scheme") introduced an undefined behaviour below due to "frag->last_in_page" is only initialized in mlx5e_init_frags_partition() when, if (next_frag.offset + frag_info[f].frag_stride > PAGE_SIZE) or after bailed out the