Re: [PATCH] net/sunrpc: Fix return value from proc_do_xprt()

2020-11-07 Thread J. Bruce Fields
On Sat, Nov 07, 2020 at 01:49:40PM +, Alex Dewar wrote: > On Fri, Nov 06, 2020 at 05:07:21PM -0500, J. Bruce Fields wrote: > > Whoops, got 3 independent patches for this and overlooked this one. See > > https://lore.kernel.org/linux-nfs/20201106205959.gb26...@fieldses.org/T/#t > > > > --b. >

Re: [PATCH] net/sunrpc: Fix return value from proc_do_xprt()

2020-11-07 Thread Alex Dewar
On Fri, Nov 06, 2020 at 05:07:21PM -0500, J. Bruce Fields wrote: > Whoops, got 3 independent patches for this and overlooked this one. See > https://lore.kernel.org/linux-nfs/20201106205959.gb26...@fieldses.org/T/#t > > --b. That looks like a cleaner fix. Thanks for looking anyhow and sorry for

Re: [PATCH] net/sunrpc: Fix return value from proc_do_xprt()

2020-11-06 Thread J. Bruce Fields
Whoops, got 3 independent patches for this and overlooked this one. See https://lore.kernel.org/linux-nfs/20201106205959.gb26...@fieldses.org/T/#t --b. On Sat, Oct 24, 2020 at 03:52:40PM +0100, Alex Dewar wrote: > Commit c09f56b8f68d ("net/sunrpc: Fix return value for sysctl > sunrpc.transports"

[PATCH] net/sunrpc: Fix return value from proc_do_xprt()

2020-10-24 Thread Alex Dewar
Commit c09f56b8f68d ("net/sunrpc: Fix return value for sysctl sunrpc.transports") attempted to add error checking for the call to memory_read_from_buffer(), however its return value was assigned to a size_t variable, so any negative values would be lost in the cast. Fix this. Addresses-Coverity-ID