Re: [PATCH] net/x25: Fix null-ptr-deref in x25_connect

2020-09-28 Thread Martin Schiller
On 2020-09-29 03:43, David Miller wrote: From: Martin Schiller Date: Mon, 28 Sep 2020 11:23:27 +0200 diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c index 0bbb283f23c9..0524a5530b91 100644 --- a/net/x25/af_x25.c +++ b/net/x25/af_x25.c @@ -820,7 +820,7 @@ static int x25_connect(struct socket

Re: [PATCH] net/x25: Fix null-ptr-deref in x25_connect

2020-09-28 Thread David Miller
From: Martin Schiller Date: Mon, 28 Sep 2020 11:23:27 +0200 > diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c > index 0bbb283f23c9..0524a5530b91 100644 > --- a/net/x25/af_x25.c > +++ b/net/x25/af_x25.c > @@ -820,7 +820,7 @@ static int x25_connect(struct socket *sock, struct > sockaddr *uaddr,

[PATCH] net/x25: Fix null-ptr-deref in x25_connect

2020-09-28 Thread Martin Schiller
This fixes a regression for blocking connects introduced by commit 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect"). The x25->neighbour is already set to "NULL" by x25_disconnect() now, while a blocking connect is waiting in x25_wait_for_connection_establishment().