Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-26 Thread Eric Dumazet
On Wed, 2016-10-26 at 18:53 +0200, Abdelrhman Ahmed wrote: > I think it's at the right place as the current one is a little different from > the > commit e1f165032c8bade3a6bdf546f8faf61fda4dd01c. > > In the next lines, skb_push is called after copying the hardware header and > there > is no

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-26 Thread Eric Dumazet
On Wed, 2016-10-26 at 18:53 +0200, Abdelrhman Ahmed wrote: > I think it's at the right place as the current one is a little different from > the > commit e1f165032c8bade3a6bdf546f8faf61fda4dd01c. > > In the next lines, skb_push is called after copying the hardware header and > there > is no

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-26 Thread Abdelrhman Ahmed
I think it's at the right place as the current one is a little different from the commit e1f165032c8bade3a6bdf546f8faf61fda4dd01c. In the next lines, skb_push is called after copying the hardware header and there is no change to the data pointer inside the retry loop. We only need to reset

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-26 Thread Abdelrhman Ahmed
I think it's at the right place as the current one is a little different from the commit e1f165032c8bade3a6bdf546f8faf61fda4dd01c. In the next lines, skb_push is called after copying the hardware header and there is no change to the data pointer inside the retry loop. We only need to reset

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-25 Thread Eric Dumazet
On Wed, 2016-10-26 at 01:57 +0200, Abdelrhman Ahmed wrote: > > What is the issue you want to fix exactly ? > > Please describe the use case. > > When netfilter hook uses skb_push to add a specific header between network > header and hardware header. > For the first time(s) before caching

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-25 Thread Eric Dumazet
On Wed, 2016-10-26 at 01:57 +0200, Abdelrhman Ahmed wrote: > > What is the issue you want to fix exactly ? > > Please describe the use case. > > When netfilter hook uses skb_push to add a specific header between network > header and hardware header. > For the first time(s) before caching

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-25 Thread Abdelrhman Ahmed
> What is the issue you want to fix exactly ? > Please describe the use case. When netfilter hook uses skb_push to add a specific header between network header and hardware header. For the first time(s) before caching hardware header, this header will be removed / overwritten by hardware

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-25 Thread Abdelrhman Ahmed
> What is the issue you want to fix exactly ? > Please describe the use case. When netfilter hook uses skb_push to add a specific header between network header and hardware header. For the first time(s) before caching hardware header, this header will be removed / overwritten by hardware

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Eric Dumazet
On Fri, 2016-10-07 at 16:14 +0200, Abdelrhman Ahmed wrote: > When hardware header is added without using cached one, neigh_resolve_output > and neigh_connected_output reset skb to network header before adding it. > When cached one is used, neigh_hh_output does not reset the skb to network >

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Eric Dumazet
On Fri, 2016-10-07 at 16:14 +0200, Abdelrhman Ahmed wrote: > When hardware header is added without using cached one, neigh_resolve_output > and neigh_connected_output reset skb to network header before adding it. > When cached one is used, neigh_hh_output does not reset the skb to network >

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Sergei Shtylyov
On 10/07/2016 07:27 PM, Sergei Shtylyov wrote: When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The fix is to

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Sergei Shtylyov
On 10/07/2016 07:27 PM, Sergei Shtylyov wrote: When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The fix is to

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Sergei Shtylyov
Hello. On 10/07/2016 05:14 PM, Abdelrhman Ahmed wrote: When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Sergei Shtylyov
Hello. On 10/07/2016 05:14 PM, Abdelrhman Ahmed wrote: When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The

[PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Abdelrhman Ahmed
When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The fix is to reset skb to network header before adding cached

[PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Abdelrhman Ahmed
When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The fix is to reset skb to network header before adding cached