Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

> That sounds really respectful with current users and sets the basis for a > future removal of that proprietary parameter without causing more harm than > needed, so I like that a lot. Please feel free to turn it into a real patch and submit it. Andrew

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

> That sounds really respectful with current users and sets the basis for a > future removal of that proprietary parameter without causing more harm than > needed, so I like that a lot. Please feel free to turn it into a real patch and submit it. Andrew

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On Wed, Jul 05, 2017 at 04:34:36PM +0200, Andrew Lunn wrote: > So the only property which is currently wrong is xlnx,phy-type. As you > said, all the others are garbage. So i would suggest something like: > > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On Wed, Jul 05, 2017 at 04:34:36PM +0200, Andrew Lunn wrote: > So the only property which is currently wrong is xlnx,phy-type. As you > said, all the others are garbage. So i would suggest something like: > > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

> Instead of the standard 'phy-mode' / 'phy-connection-type' values, the > driver uses of_property_read_u32(pdev->dev.of_node, "xlnx,phy-type", > >phy_type). > > I think the reason for this is that Xilinx provides a utility to generate > device trees from a Vivado/ISE project, which outputs

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

> Instead of the standard 'phy-mode' / 'phy-connection-type' values, the > driver uses of_property_read_u32(pdev->dev.of_node, "xlnx,phy-type", > >phy_type). > > I think the reason for this is that Xilinx provides a utility to generate > device trees from a Vivado/ISE project, which outputs

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On Tue, Jul 04, 2017 at 09:24:03AM -0700, Florian Fainelli wrote: > On July 2, 2017 3:19:14 AM PDT, Alvaro Gamez Machado > wrote: > >On Fri, Jun 30, 2017 at 10:30:38AM -0700, Florian Fainelli wrote: > >> On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: > >> >

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On Tue, Jul 04, 2017 at 09:24:03AM -0700, Florian Fainelli wrote: > On July 2, 2017 3:19:14 AM PDT, Alvaro Gamez Machado > wrote: > >On Fri, Jun 30, 2017 at 10:30:38AM -0700, Florian Fainelli wrote: > >> On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: > >> > if (lp->phy_node) { > >>

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On July 2, 2017 3:19:14 AM PDT, Alvaro Gamez Machado wrote: >On Fri, Jun 30, 2017 at 10:30:38AM -0700, Florian Fainelli wrote: >> On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: >> >if (lp->phy_node) { >> > - if (lp->phy_type == XAE_PHY_TYPE_GMII) { >> >

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On July 2, 2017 3:19:14 AM PDT, Alvaro Gamez Machado wrote: >On Fri, Jun 30, 2017 at 10:30:38AM -0700, Florian Fainelli wrote: >> On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: >> >if (lp->phy_node) { >> > - if (lp->phy_type == XAE_PHY_TYPE_GMII) { >> > + if

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On Fri, Jun 30, 2017 at 10:30:38AM -0700, Florian Fainelli wrote: > On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: > > if (lp->phy_node) { > > - if (lp->phy_type == XAE_PHY_TYPE_GMII) { > > + if (lp->phy_type == XAE_PHY_TYPE_MII) { > > + phydev =

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On Fri, Jun 30, 2017 at 10:30:38AM -0700, Florian Fainelli wrote: > On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: > > if (lp->phy_node) { > > - if (lp->phy_type == XAE_PHY_TYPE_GMII) { > > + if (lp->phy_type == XAE_PHY_TYPE_MII) { > > + phydev =

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: > This IP core has support for mii connectivity to the phy, so be ready to > connect to it when this is the case. > > Signed-off-by: Alvaro Gamez Machado > --- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6

Re: [PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

On 06/30/2017 02:25 AM, Alvaro Gamez Machado wrote: > This IP core has support for mii connectivity to the phy, so be ready to > connect to it when this is the case. > > Signed-off-by: Alvaro Gamez Machado > --- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +- > 1 file changed, 5

[PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

This IP core has support for mii connectivity to the phy, so be ready to connect to it when this is the case. Signed-off-by: Alvaro Gamez Machado --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH] net: axienet: add of_phy_connect call for XAE_PHY_TYPE_MII case

This IP core has support for mii connectivity to the phy, so be ready to connect to it when this is the case. Signed-off-by: Alvaro Gamez Machado --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git