Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-09 Thread David Miller
From: Denys Vlasenko Date: Thu, 7 May 2015 13:41:10 +0200 > These functions compile to ~60 bytes of machine code each. As others have suggested, just kill the WARN_ON(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-09 Thread David Miller
From: Denys Vlasenko dvlas...@redhat.com Date: Thu, 7 May 2015 13:41:10 +0200 These functions compile to ~60 bytes of machine code each. As others have suggested, just kill the WARN_ON(). -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-08 Thread Alexei Starovoitov
On Fri, May 08, 2015 at 08:50:37AM -0700, Alexander Duyck wrote: > > >>> f0 80 8f e0 01 00 00 01 lock orb $0x1,0x1e0(%rdi) > >>This is your set bit operation. If you were to drop the whole WARN_ON > >>then this is the only thing you would be inlining. > >It's up to networking people to

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-08 Thread Alexander Duyck
On 05/08/2015 02:45 AM, Denys Vlasenko wrote: On 05/07/2015 07:14 PM, Alexander Duyck wrote: On 05/07/2015 04:41 AM, Denys Vlasenko wrote: These functions compile to ~60 bytes of machine code each. With this .config: http://busybox.net/~vda/kernel_config there are 617 calls to

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-08 Thread Denys Vlasenko
On 05/07/2015 07:14 PM, Alexander Duyck wrote: > On 05/07/2015 04:41 AM, Denys Vlasenko wrote: >> These functions compile to ~60 bytes of machine code each. >> >> With this .config: http://busybox.net/~vda/kernel_config >> there are 617 calls to netif_tx_stop_queue() >> and 49 calls to

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-08 Thread Denys Vlasenko
On 05/07/2015 07:14 PM, Alexander Duyck wrote: On 05/07/2015 04:41 AM, Denys Vlasenko wrote: These functions compile to ~60 bytes of machine code each. With this .config: http://busybox.net/~vda/kernel_config there are 617 calls to netif_tx_stop_queue() and 49 calls to

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-08 Thread Alexei Starovoitov
On Fri, May 08, 2015 at 08:50:37AM -0700, Alexander Duyck wrote: f0 80 8f e0 01 00 00 01 lock orb $0x1,0x1e0(%rdi) This is your set bit operation. If you were to drop the whole WARN_ON then this is the only thing you would be inlining. It's up to networking people to decide. I

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-08 Thread Alexander Duyck
On 05/08/2015 02:45 AM, Denys Vlasenko wrote: On 05/07/2015 07:14 PM, Alexander Duyck wrote: On 05/07/2015 04:41 AM, Denys Vlasenko wrote: These functions compile to ~60 bytes of machine code each. With this .config: http://busybox.net/~vda/kernel_config there are 617 calls to

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-07 Thread Joe Perches
On Thu, 2015-05-07 at 10:14 -0700, Alexander Duyck wrote: > On 05/07/2015 04:41 AM, Denys Vlasenko wrote: > > These functions compile to ~60 bytes of machine code each. > > > > With this .config: http://busybox.net/~vda/kernel_config > > there are 617 calls to netif_tx_stop_queue() > > and 49

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-07 Thread Alexander Duyck
On 05/07/2015 04:41 AM, Denys Vlasenko wrote: These functions compile to ~60 bytes of machine code each. With this .config: http://busybox.net/~vda/kernel_config there are 617 calls to netif_tx_stop_queue() and 49 calls to netif_tx_stop_all_queues() in vmlinux. Code size is reduced by 27

[PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-07 Thread Denys Vlasenko
These functions compile to ~60 bytes of machine code each. With this .config: http://busybox.net/~vda/kernel_config there are 617 calls to netif_tx_stop_queue() and 49 calls to netif_tx_stop_all_queues() in vmlinux. Code size is reduced by 27 kbytes: text data bss dec hex

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-07 Thread Joe Perches
On Thu, 2015-05-07 at 10:14 -0700, Alexander Duyck wrote: On 05/07/2015 04:41 AM, Denys Vlasenko wrote: These functions compile to ~60 bytes of machine code each. With this .config: http://busybox.net/~vda/kernel_config there are 617 calls to netif_tx_stop_queue() and 49 calls to

[PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-07 Thread Denys Vlasenko
These functions compile to ~60 bytes of machine code each. With this .config: http://busybox.net/~vda/kernel_config there are 617 calls to netif_tx_stop_queue() and 49 calls to netif_tx_stop_all_queues() in vmlinux. Code size is reduced by 27 kbytes: text data bss dec hex

Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues()

2015-05-07 Thread Alexander Duyck
On 05/07/2015 04:41 AM, Denys Vlasenko wrote: These functions compile to ~60 bytes of machine code each. With this .config: http://busybox.net/~vda/kernel_config there are 617 calls to netif_tx_stop_queue() and 49 calls to netif_tx_stop_all_queues() in vmlinux. Code size is reduced by 27