Re: [PATCH] net: don't forget to free sk_filter

2013-11-07 Thread Eric Dumazet
On Fri, 2013-11-08 at 00:56 +, Keller, Jacob E wrote: > Has there been any mention of a forthcoming patch > to ./Documentation/SubmittingPatches which documents this? I do not remember if this point was raised, but you certainly can submit a patch ! Thanks -- To unsubscribe from this

Re: [PATCH] net: don't forget to free sk_filter

2013-11-07 Thread Keller, Jacob E
On Wed, 2013-11-06 at 11:28 -0800, Eric Dumazet wrote: > On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: > > > When you send v2 with Alexei's feedback, please also be more specific > > in your subject like "net: x86: bpf: don't forget to free sk_filter" > > or the like. Also it's enough

Re: [PATCH] net: don't forget to free sk_filter

2013-11-07 Thread Keller, Jacob E
On Wed, 2013-11-06 at 11:28 -0800, Eric Dumazet wrote: On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: When you send v2 with Alexei's feedback, please also be more specific in your subject like net: x86: bpf: don't forget to free sk_filter or the like. Also it's enough to say

Re: [PATCH] net: don't forget to free sk_filter

2013-11-07 Thread Eric Dumazet
On Fri, 2013-11-08 at 00:56 +, Keller, Jacob E wrote: Has there been any mention of a forthcoming patch to ./Documentation/SubmittingPatches which documents this? I do not remember if this point was raised, but you certainly can submit a patch ! Thanks -- To unsubscribe from this list:

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread David Miller
From: Eric Dumazet Date: Wed, 06 Nov 2013 11:28:18 -0800 > On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: > >> When you send v2 with Alexei's feedback, please also be more specific >> in your subject like "net: x86: bpf: don't forget to free sk_filter" >> or the like. Also it's

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Alexei Starovoitov
On Wed, Nov 6, 2013 at 11:28 AM, Eric Dumazet wrote: > Actually, the new way [1] of doing this would be to use the 'Fixes:' tag > as in : > > Fixes: <12 digits SHA1> ("net: fix unsafe set_memory_rw from softirq") > > [1] As discussed at last Kernel Summit thx. good to know. Unfortunately 2013

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Daniel Borkmann
On 11/06/2013 08:28 PM, Eric Dumazet wrote: On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: When you send v2 with Alexei's feedback, please also be more specific in your subject like "net: x86: bpf: don't forget to free sk_filter" or the like. Also it's enough to say 'This memory

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Eric Dumazet
On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: > When you send v2 with Alexei's feedback, please also be more specific > in your subject like "net: x86: bpf: don't forget to free sk_filter" > or the like. Also it's enough to say 'This memory leak was introduced > by commit d45ed4a4e3

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Daniel Borkmann
On 11/06/2013 04:51 PM, Andrey Vagin wrote: sk_filter isn't freed if bpf_func is equal to sk_run_filter. This memory leak was introduced by commit d45ed4a4e33ae103053c0a53d280014e7101bb5c Author: Alexei Starovoitov Date: Fri Oct 4 00:14:06 2013 -0700 net: fix unsafe set_memory_rw from

[PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Andrey Vagin
sk_filter isn't freed if bpf_func is equal to sk_run_filter. This memory leak was introduced by commit d45ed4a4e33ae103053c0a53d280014e7101bb5c Author: Alexei Starovoitov Date: Fri Oct 4 00:14:06 2013 -0700 net: fix unsafe set_memory_rw from softirq Before this patch sk_filter was freed

[PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Andrey Vagin
sk_filter isn't freed if bpf_func is equal to sk_run_filter. This memory leak was introduced by commit d45ed4a4e33ae103053c0a53d280014e7101bb5c Author: Alexei Starovoitov a...@plumgrid.com Date: Fri Oct 4 00:14:06 2013 -0700 net: fix unsafe set_memory_rw from softirq Before this patch

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Daniel Borkmann
On 11/06/2013 04:51 PM, Andrey Vagin wrote: sk_filter isn't freed if bpf_func is equal to sk_run_filter. This memory leak was introduced by commit d45ed4a4e33ae103053c0a53d280014e7101bb5c Author: Alexei Starovoitov a...@plumgrid.com Date: Fri Oct 4 00:14:06 2013 -0700 net: fix unsafe

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Eric Dumazet
On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: When you send v2 with Alexei's feedback, please also be more specific in your subject like net: x86: bpf: don't forget to free sk_filter or the like. Also it's enough to say 'This memory leak was introduced by commit d45ed4a4e3 (net:

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Daniel Borkmann
On 11/06/2013 08:28 PM, Eric Dumazet wrote: On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: When you send v2 with Alexei's feedback, please also be more specific in your subject like net: x86: bpf: don't forget to free sk_filter or the like. Also it's enough to say 'This memory leak

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread Alexei Starovoitov
On Wed, Nov 6, 2013 at 11:28 AM, Eric Dumazet eric.duma...@gmail.com wrote: Actually, the new way [1] of doing this would be to use the 'Fixes:' tag as in : Fixes: 12 digits SHA1 (net: fix unsafe set_memory_rw from softirq) [1] As discussed at last Kernel Summit thx. good to know.

Re: [PATCH] net: don't forget to free sk_filter

2013-11-06 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 06 Nov 2013 11:28:18 -0800 On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: When you send v2 with Alexei's feedback, please also be more specific in your subject like net: x86: bpf: don't forget to free sk_filter or the like.