Re: [PATCH] net: dsa: sja1105: sja1105_main: Add of_node_put()

2019-07-24 Thread Vladimir Oltean
On Tue, 23 Jul 2019 at 23:38, David Miller wrote: > > From: Nishka Dasgupta > Date: Tue, 23 Jul 2019 16:14:48 +0530 > > > Each iteration of for_each_child_of_node puts the previous node, but in > > the case of a return from the middle of the loop, there is no put, thus > > causing a memory leak.

Re: [PATCH] net: dsa: sja1105: sja1105_main: Add of_node_put()

2019-07-23 Thread David Miller
From: Nishka Dasgupta Date: Tue, 23 Jul 2019 16:14:48 +0530 > Each iteration of for_each_child_of_node puts the previous node, but in > the case of a return from the middle of the loop, there is no put, thus > causing a memory leak. Hence add an of_node_put before the return. > Issue found with

[PATCH] net: dsa: sja1105: sja1105_main: Add of_node_put()

2019-07-23 Thread Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta ---