Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring

2019-08-08 Thread Matthew Wilcox
On Wed, Aug 07, 2019 at 10:23:46PM -0700, Jesse Brandeburg wrote: > On Wed, 31 Jul 2019 09:38:42 +0200 > Christophe JAILLET wrote: > > > There is no good reason to use GFP_ATOMIC here. Other memory allocations > > are performed with GFP_KERNEL (see other 'dma_alloc_coherent()' below and > >

Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring

2019-08-07 Thread Jesse Brandeburg
On Wed, 31 Jul 2019 09:38:42 +0200 Christophe JAILLET wrote: > There is no good reason to use GFP_ATOMIC here. Other memory allocations > are performed with GFP_KERNEL (see other 'dma_alloc_coherent()' below and > 'kzalloc()' in 'et131x_rx_dma_memory_alloc()') > > Use GFP_KERNEL which should be

Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring

2019-07-31 Thread David Miller
From: Christophe JAILLET Date: Wed, 31 Jul 2019 09:38:42 +0200 > There is no good reason to use GFP_ATOMIC here. Other memory allocations > are performed with GFP_KERNEL (see other 'dma_alloc_coherent()' below and > 'kzalloc()' in 'et131x_rx_dma_memory_alloc()') > > Use GFP_KERNEL which should

[PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring

2019-07-31 Thread Christophe JAILLET
There is no good reason to use GFP_ATOMIC here. Other memory allocations are performed with GFP_KERNEL (see other 'dma_alloc_coherent()' below and 'kzalloc()' in 'et131x_rx_dma_memory_alloc()') Use GFP_KERNEL which should be enough. Signed-off-by: Christophe JAILLET ---