Re: [PATCH] net: ethernet: mediatek: fix warning in phy_start_aneg

2019-01-08 Thread Heiner Kallweit
On 08.01.2019 20:29, Sean Wang wrote: > On Tue, Jan 8, 2019 at 11:07 AM Frank Wunderlich > wrote: >> >> >>> In mtk_phy_connect() I would say this complete block can be removed. >>> All this is handled internally by phylib. >>> >>> dev->phydev->autoneg = AUTONEG_ENABLE; >>>

Re: Re: [PATCH] net: ethernet: mediatek: fix warning in phy_start_aneg

2019-01-08 Thread Sean Wang
On Tue, Jan 8, 2019 at 11:07 AM Frank Wunderlich wrote: > > > > In mtk_phy_connect() I would say this complete block can be removed. > > All this is handled internally by phylib. > > > > dev->phydev->autoneg = AUTONEG_ENABLE; > > dev->phydev->speed = 0; > > dev->phydev->duplex =

Aw: Re: [PATCH] net: ethernet: mediatek: fix warning in phy_start_aneg

2019-01-08 Thread Frank Wunderlich
> In mtk_phy_connect() I would say this complete block can be removed. > All this is handled internally by phylib. > > dev->phydev->autoneg = AUTONEG_ENABLE; > dev->phydev->speed = 0; > dev->phydev->duplex = 0; > > phy_set_max_speed(dev->phydev, SPEED_1000); >

Re: [PATCH] net: ethernet: mediatek: fix warning in phy_start_aneg

2019-01-08 Thread Heiner Kallweit
On 08.01.2019 17:05, Frank Wunderlich wrote: > From: Sean Wang > > linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup: > > [ 5.170597] WARNING: CPU: 3 PID: 1 at drivers/net/phy/phy.c:548 > phy_start_aneg+0x110/0x144 > [ 5.178826] called from state READY > > [ 5.264111] []

[PATCH] net: ethernet: mediatek: fix warning in phy_start_aneg

2019-01-08 Thread Frank Wunderlich
From: Sean Wang linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup: [ 5.170597] WARNING: CPU: 3 PID: 1 at drivers/net/phy/phy.c:548 phy_start_aneg+0x110/0x144 [ 5.178826] called from state READY [ 5.264111] [] (phy_start_aneg) from [] (mtk_init+0x414/0x47c) [ 5.271630]