Hi david,
On 10/05/15 03:01, David Miller wrote:
From: Philippe Reynes
Date: Sun, 10 May 2015 00:16:21 +0200
Hi Fabio,
On 09/05/15 23:59, Fabio Estevam wrote:
Philippe,
On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
wrote:
Using memcpy_fromio() to copy device registers is
Hi david,
On 10/05/15 03:01, David Miller wrote:
From: Philippe Reynestrem...@gmail.com
Date: Sun, 10 May 2015 00:16:21 +0200
Hi Fabio,
On 09/05/15 23:59, Fabio Estevam wrote:
Philippe,
On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Using
From: Philippe Reynes
Date: Sun, 10 May 2015 00:16:21 +0200
> Hi Fabio,
>
> On 09/05/15 23:59, Fabio Estevam wrote:
>> Philippe,
>>
>> On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
>> wrote:
>>
>>> Using memcpy_fromio() to copy device registers is not a good idea -
>>> it can use a
Hi Fabio,
On 09/05/15 23:59, Fabio Estevam wrote:
Philippe,
On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
wrote:
Using memcpy_fromio() to copy device registers is not a good idea -
it can use a variable access size which can cause bus faults.
An example on how memcpy_fromio()
Philippe,
On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
wrote:
> Using memcpy_fromio() to copy device registers is not a good idea -
> it can use a variable access size which can cause bus faults.
An example on how memcpy_fromio() can be avoided in get_regs:
From: Russell King - ARM Linux
Date: Sat, 9 May 2015 22:17:46 +0100
> On Sat, May 09, 2015 at 10:52:08PM +0200, Philippe Reynes wrote:
>> +static void fec_enet_get_regs(struct net_device *ndev,
>> + struct ethtool_regs *regs, void *regbuf)
>> +{
>> +struct
On Sat, May 09, 2015 at 10:52:08PM +0200, Philippe Reynes wrote:
> +static void fec_enet_get_regs(struct net_device *ndev,
> + struct ethtool_regs *regs, void *regbuf)
> +{
> + struct fec_enet_private *fep = netdev_priv(ndev);
> +
> + memcpy_fromio(regbuf,
This enables the ethtool's "-d" and "--register-dump"
options for fec devices.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/freescale/fec_main.c | 24
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
On Sat, May 09, 2015 at 10:52:08PM +0200, Philippe Reynes wrote:
+static void fec_enet_get_regs(struct net_device *ndev,
+ struct ethtool_regs *regs, void *regbuf)
+{
+ struct fec_enet_private *fep = netdev_priv(ndev);
+
+ memcpy_fromio(regbuf, fep-hwp,
From: Philippe Reynes trem...@gmail.com
Date: Sun, 10 May 2015 00:16:21 +0200
Hi Fabio,
On 09/05/15 23:59, Fabio Estevam wrote:
Philippe,
On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Using memcpy_fromio() to copy device registers is not a good
Hi Fabio,
On 09/05/15 23:59, Fabio Estevam wrote:
Philippe,
On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Using memcpy_fromio() to copy device registers is not a good idea -
it can use a variable access size which can cause bus faults.
An example
This enables the ethtool's -d and --register-dump
options for fec devices.
Signed-off-by: Philippe Reynes trem...@gmail.com
---
drivers/net/ethernet/freescale/fec_main.c | 24
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git
From: Russell King - ARM Linux li...@arm.linux.org.uk
Date: Sat, 9 May 2015 22:17:46 +0100
On Sat, May 09, 2015 at 10:52:08PM +0200, Philippe Reynes wrote:
+static void fec_enet_get_regs(struct net_device *ndev,
+ struct ethtool_regs *regs, void *regbuf)
+{
+
Philippe,
On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Using memcpy_fromio() to copy device registers is not a good idea -
it can use a variable access size which can cause bus faults.
An example on how memcpy_fromio() can be avoided in get_regs:
14 matches
Mail list logo