RE: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg

2020-09-14 Thread David Laight
From: Greg KH > Sent: 13 September 2020 07:14 > On Sun, Sep 13, 2020 at 11:26:39AM +0530, Anant Thazhemadam wrote: > > The crash report showed that there was a local variable; > > > > iovstack.i@__sys_sendmmsg created at: > > ___sys_sendmsg net/socket.c:2388 [inline] > >

Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg

2020-09-13 Thread Anant Thazhemadam
I can assure you that when I said "I think", I meant it in an assertive manner, and not an assumptive one, but I can understand how that could easily get lost in translation. I wouldn't have sent in the patch if I had caught the build warning, and once again, my apologies for not fixing it

Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg

2020-09-13 Thread David Miller
From: Anant Thazhemadam Date: Sun, 13 Sep 2020 11:50:52 +0530 > My apologies. I think I ended up overlooking the build warning. You "think" you overlooked the build warning? You don't actually know? If you aren't willing to even make sure the build is clean after your changes, why should we

Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg

2020-09-13 Thread Anant Thazhemadam
On 13/09/20 11:43 am, Greg KH wrote: > On Sun, Sep 13, 2020 at 11:26:39AM +0530, Anant Thazhemadam wrote: >> The crash report showed that there was a local variable; >> >> iovstack.i@__sys_sendmmsg created at: >> ___sys_sendmsg net/socket.c:2388 [inline] >> __sys_sendmmsg+0x6db/0xc90

Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg

2020-09-13 Thread Greg KH
On Sun, Sep 13, 2020 at 11:26:39AM +0530, Anant Thazhemadam wrote: > The crash report showed that there was a local variable; > > iovstack.i@__sys_sendmmsg created at: > ___sys_sendmsg net/socket.c:2388 [inline] > __sys_sendmmsg+0x6db/0xc90 net/socket.c:2480 > > that was left

[PATCH] net: fix uninit value error in __sys_sendmmsg

2020-09-12 Thread Anant Thazhemadam
The crash report showed that there was a local variable; iovstack.i@__sys_sendmmsg created at: ___sys_sendmsg net/socket.c:2388 [inline] __sys_sendmmsg+0x6db/0xc90 net/socket.c:2480 that was left uninitialized. The contents of iovstack are of interest, since the respective pointer is