Re: [PATCH] net: ipv4: current group_info should be put after using.

2014-05-11 Thread Mateusz Guzik
On Sun, Apr 13, 2014 at 10:54:07PM -0400, David Miller wrote: > From: "Wang, Xiaoming" > Date: Mon, 14 Apr 2014 12:30:45 -0400 > > > Plug a group_info refcount leak in ping_init. > > group_info is only needed during initialization and > > the code failed to release the reference on exit. > > Whi

Re: [PATCH] net: ipv4: current group_info should be put after using.

2014-04-13 Thread David Miller
From: "Wang, Xiaoming" Date: Mon, 14 Apr 2014 12:30:45 -0400 > Plug a group_info refcount leak in ping_init. > group_info is only needed during initialization and > the code failed to release the reference on exit. > While here move grabbing the reference to a place > where it is actually neede

[PATCH] net: ipv4: current group_info should be put after using.

2014-04-13 Thread Wang, Xiaoming
Plug a group_info refcount leak in ping_init. group_info is only needed during initialization and the code failed to release the reference on exit. While here move grabbing the reference to a place where it is actually needed. Signed-off-by: Chuansheng Liu Signed-off-by: Zhang Dongxing Signed-

Re: [PATCH] net: ipv4: current group_info should be put after using.

2014-04-12 Thread David Miller
From: Mateusz Guzik Date: Fri, 11 Apr 2014 15:50:27 +0200 > Please cc: me if you resend the patch. Never resubmit a patch as a reply to a thread discussion a previous version of the patch if you want it to be considered for inclusion. Always make a new, fresh, mailing list posting properly form

Re: [PATCH] net: ipv4: current group_info should be put after using.

2014-04-11 Thread Mateusz Guzik
On Fri, Apr 11, 2014 at 10:53:21PM -0400, Wang, Xiaoming wrote: > This is a typical refcount leak exploitable by unprivileged users. > Current group_info had been got in ping_init_sock and > group_info->usage increased. But the usage hasn't decreased > anywhere in ping. This will make this group_in

Re: [PATCH] net: ipv4: current group_info should be put after using.

2014-04-11 Thread Mateusz Guzik
On Fri, Apr 11, 2014 at 10:35:33AM +0200, Mateusz Guzik wrote: > On Fri, Apr 11, 2014 at 01:37:08PM -0400, Wang, Xiaoming wrote: > > There is a memory leak in ping. Current group_info had been got in > > ping_init_sock and group_info->usage increased. > > But the usage hasn't decreased anywhere i

[PATCH] net: ipv4: current group_info should be put after using.

2014-04-11 Thread Wang, Xiaoming
This is a typical refcount leak exploitable by unprivileged users. Current group_info had been got in ping_init_sock and group_info->usage increased. But the usage hasn't decreased anywhere in ping. This will make this group_info never freed. Signed-off-by: Chuansheng Liu Signed-off-by: Zhang Don

Re: [PATCH] net: ipv4: current group_info should be put after using.

2014-04-11 Thread Mateusz Guzik
On Fri, Apr 11, 2014 at 01:37:08PM -0400, Wang, Xiaoming wrote: > There is a memory leak in ping. Current group_info had been got in > ping_init_sock and group_info->usage increased. > But the usage hasn't decreased anywhere in ping. > This will make this group_info never freed and cause memory l

[PATCH] net: ipv4: current group_info should be put after using.

2014-04-10 Thread Wang, Xiaoming
There is a memory leak in ping. Current group_info had been got in ping_init_sock and group_info->usage increased. But the usage hasn't decreased anywhere in ping. This will make this group_info never freed and cause memory leak. unreferenced object 0xcd0e8840 (size 192): comm "dumpstate", pid

Re: [PATCH] net: ipv4: current group_info should be put after using.

2014-04-10 Thread David Miller
From: "Wang, Xiaoming" Date: Fri, 11 Apr 2014 12:10:38 -0400 > +EXIT: Do not use all CAPS names for local labels. Make the label, in lower case, say something about what state needs to be released at that point. Something like "out_release_group:" -- To unsubscribe from this list: send the lin

[PATCH] net: ipv4: current group_info should be put after using.

2014-04-10 Thread Wang, Xiaoming
There is a memory leak in ping when call ping in dumpstate. Current group_info had been got in ping_init_sock and group_info->usage increased. But the usage hasn't decreased. This will make group_info never freed and cause memory leak. unreferenced object 0xcd0e8840 (size 192): comm "dumpstate",