Re: [PATCH] net: ipv4: fib_semantics: fix uninitialized variable

2019-06-09 Thread David Miller
From: "Enrico Weigelt, metux IT consult" Date: Thu, 6 Jun 2019 16:43:17 +0200 > From: Enrico Weigelt > > fix an uninitialized variable: > > CC net/ipv4/fib_semantics.o > net/ipv4/fib_semantics.c: In function 'fib_check_nh_v4_gw': > net/ipv4/fib_semantics.c:1027:12: warning: 'err' may

Re: [PATCH] net: ipv4: fib_semantics: fix uninitialized variable

2019-06-06 Thread Enrico Weigelt, metux IT consult
On 06.06.19 17:47, David Ahern wrote: > > what compiler version? > > if tbl is set, then err is set. > gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: [PATCH] net: ipv4: fib_semantics: fix uninitialized variable

2019-06-06 Thread David Miller
From: David Ahern Date: Thu, 6 Jun 2019 09:47:34 -0600 > On 6/6/19 8:43 AM, Enrico Weigelt, metux IT consult wrote: >> From: Enrico Weigelt >> >> fix an uninitialized variable: >> >> CC net/ipv4/fib_semantics.o >> net/ipv4/fib_semantics.c: In function 'fib_check_nh_v4_gw': >>

Re: [PATCH] net: ipv4: fib_semantics: fix uninitialized variable

2019-06-06 Thread David Ahern
On 6/6/19 8:43 AM, Enrico Weigelt, metux IT consult wrote: > From: Enrico Weigelt > > fix an uninitialized variable: > > CC net/ipv4/fib_semantics.o > net/ipv4/fib_semantics.c: In function 'fib_check_nh_v4_gw': > net/ipv4/fib_semantics.c:1027:12: warning: 'err' may be used uninitialized

[PATCH] net: ipv4: fib_semantics: fix uninitialized variable

2019-06-06 Thread Enrico Weigelt, metux IT consult
From: Enrico Weigelt fix an uninitialized variable: CC net/ipv4/fib_semantics.o net/ipv4/fib_semantics.c: In function 'fib_check_nh_v4_gw': net/ipv4/fib_semantics.c:1027:12: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] if (!tbl || err) {