RE: [PATCH] net: macb: add phy-handle support for the macb

2016-08-19 Thread Appana Durga Kedareswara Rao
Hi Andrew, Thanks for the review... > > > Agree with you my intention is if there is a MDIO bus on the > > device-tree The MAC driver should create PHY/MDIO devices using > of_mdiobus_register(). > > What you suggest is better, and is similar to what other drivers use. > > In order to

RE: [PATCH] net: macb: add phy-handle support for the macb

2016-08-19 Thread Appana Durga Kedareswara Rao
Hi Andrew, Thanks for the review... > > > Agree with you my intention is if there is a MDIO bus on the > > device-tree The MAC driver should create PHY/MDIO devices using > of_mdiobus_register(). > > What you suggest is better, and is similar to what other drivers use. > > In order to

Re: [PATCH] net: macb: add phy-handle support for the macb

2016-08-16 Thread Andrew Lunn
> Agree with you my intention is if there is a MDIO bus on the device-tree > The MAC driver should create PHY/MDIO devices using of_mdiobus_register(). What you suggest is better, and is similar to what other drivers use. In order to keep backwards compatibility with phy nodes in the MAC node,

Re: [PATCH] net: macb: add phy-handle support for the macb

2016-08-16 Thread Andrew Lunn
> Agree with you my intention is if there is a MDIO bus on the device-tree > The MAC driver should create PHY/MDIO devices using of_mdiobus_register(). What you suggest is better, and is similar to what other drivers use. In order to keep backwards compatibility with phy nodes in the MAC node,

RE: [PATCH] net: macb: add phy-handle support for the macb

2016-08-16 Thread Appana Durga Kedareswara Rao
Hi David Miller, Thanks for the review... > > From: Kedareswara rao Appana > Date: Sat, 13 Aug 2016 15:31:49 +0530 > > > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > > dev_set_drvdata(>dev->dev, bp->mii_bus); > > > > np =

RE: [PATCH] net: macb: add phy-handle support for the macb

2016-08-16 Thread Appana Durga Kedareswara Rao
Hi David Miller, Thanks for the review... > > From: Kedareswara rao Appana > Date: Sat, 13 Aug 2016 15:31:49 +0530 > > > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > > dev_set_drvdata(>dev->dev, bp->mii_bus); > > > > np = bp->pdev->dev.of_node; > > - if

Re: [PATCH] net: macb: add phy-handle support for the macb

2016-08-14 Thread David Miller
From: Kedareswara rao Appana Date: Sat, 13 Aug 2016 15:31:49 +0530 > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > dev_set_drvdata(>dev->dev, bp->mii_bus); > > np = bp->pdev->dev.of_node; > - if (np) { > + np1 =

Re: [PATCH] net: macb: add phy-handle support for the macb

2016-08-14 Thread David Miller
From: Kedareswara rao Appana Date: Sat, 13 Aug 2016 15:31:49 +0530 > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > dev_set_drvdata(>dev->dev, bp->mii_bus); > > np = bp->pdev->dev.of_node; > - if (np) { > + np1 = of_get_parent(bp->phy_node); > + if

[PATCH] net: macb: add phy-handle support for the macb

2016-08-13 Thread Kedareswara rao Appana
This patch adds support for the 'phy-handle' binding which allows for a system to specifically select a phy which can be attached via any MDIO bus available in the system. Signed-off-by: Kedareswara rao Appana --- Documentation/devicetree/bindings/net/macb.txt | 3 +++

[PATCH] net: macb: add phy-handle support for the macb

2016-08-13 Thread Kedareswara rao Appana
This patch adds support for the 'phy-handle' binding which allows for a system to specifically select a phy which can be attached via any MDIO bus available in the system. Signed-off-by: Kedareswara rao Appana --- Documentation/devicetree/bindings/net/macb.txt | 3 +++