Re: [PATCH] net: optimize cmpxchg in ip_idents_reserve

2020-05-07 Thread Eric Dumazet
On Thu, May 7, 2020 at 2:12 AM Shaokun Zhang wrote: > > Hi Peter/Eric, > > Shall we use atomic_add_return() unconditionally and add some comments? Or I > missed > something. > Yes. A big fat comment, because I do not want yet another bogus complaint from someone playing with a buggy UBSAN.

Re: [PATCH] net: optimize cmpxchg in ip_idents_reserve

2020-05-07 Thread Shaokun Zhang
Hi Peter/Eric, Shall we use atomic_add_return() unconditionally and add some comments? Or I missed something. Thanks, Shaokun On 2020/1/20 16:18, Peter Zijlstra wrote: > On Fri, Jan 17, 2020 at 10:48:19AM -0800, Eric Dumazet wrote: >> >> >> On 1/17/20 10:38 AM, Arvind Sankar wrote: >>> On Fri,