Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 3:59 AM Dejin Zheng wrote: > On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote: > > (Markus is clearly not taking the hint, but FYI for everyone else:) > Brian, Thanks very much for your reminder, These comments have always > bothered me. Now I can put it on my

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Dejin Zheng
On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote: > (Markus is clearly not taking the hint, but FYI for everyone else:) > > On Mon, May 4, 2020 at 8:00 AM Markus Elfring wrote: > > > BTW, In the past week, you asked me to change the commit comments in my > > > 6 patches like this

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Brian Norris
(Markus is clearly not taking the hint, but FYI for everyone else:) On Mon, May 4, 2020 at 8:00 AM Markus Elfring wrote: > > BTW, In the past week, you asked me to change the commit comments in my > > 6 patches like this one. Let me return to the essence of patch, point > > out the code problems

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
>>> the related system resources were not released when pci_iomap() return >>> error in the rtw_pci_io_mapping() function. add pci_release_regions() to >>> fix it. >> >> How do you think about a wording variant like the following? >> >>Subject: >>[PATCH v2] net: rtw88: Complete exception

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
> the related system resources were not released when pci_iomap() return > error in the rtw_pci_io_mapping() function. add pci_release_regions() to > fix it. How do you think about a wording variant like the following? Subject: [PATCH v2] net: rtw88: Complete exception handling in