Re: [PATCH] net: stmmac: unify registers dumps methods

2017-02-24 Thread David Miller
From: Corentin Labbe Date: Thu, 23 Feb 2017 14:12:25 +0100 > The stmmac driver have two methods for registers dumps: via ethtool and > at init (if NETIF_MSG_HW is enabled). > > It is better to keep only one method, ethtool, since the other was ugly. > > This patch

Re: [PATCH] net: stmmac: unify registers dumps methods

2017-02-24 Thread David Miller
From: Corentin Labbe Date: Thu, 23 Feb 2017 14:12:25 +0100 > The stmmac driver have two methods for registers dumps: via ethtool and > at init (if NETIF_MSG_HW is enabled). > > It is better to keep only one method, ethtool, since the other was ugly. > > This patch convert all dump_regs()

[PATCH] net: stmmac: unify registers dumps methods

2017-02-23 Thread Corentin Labbe
The stmmac driver have two methods for registers dumps: via ethtool and at init (if NETIF_MSG_HW is enabled). It is better to keep only one method, ethtool, since the other was ugly. This patch convert all dump_regs() function from "printing regs" to "fill the reg_space used by ethtool".

[PATCH] net: stmmac: unify registers dumps methods

2017-02-23 Thread Corentin Labbe
The stmmac driver have two methods for registers dumps: via ethtool and at init (if NETIF_MSG_HW is enabled). It is better to keep only one method, ethtool, since the other was ugly. This patch convert all dump_regs() function from "printing regs" to "fill the reg_space used by ethtool".