Re: [PATCH] net: tundra: tsi108: use spin_lock_irqsave instead of spin_lock_irq in IRQ context

2019-08-08 Thread David Miller
From: Fuqian Huang Date: Wed, 7 Aug 2019 15:43:00 +0800 > @@ -372,8 +372,9 @@ static void tsi108_stat_carry(struct net_device *dev) > { > struct tsi108_prv_data *data = netdev_priv(dev); > u32 carry1, carry2; > + unsigned long flags; Please preserve reverse christmas tree

[PATCH] net: tundra: tsi108: use spin_lock_irqsave instead of spin_lock_irq in IRQ context

2019-08-07 Thread Fuqian Huang
As spin_unlock_irq will enable interrupts. Function tsi108_stat_carry is called from interrupt handler tsi108_irq. Interrupts are enabled in interrupt handler. Use spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq in IRQ context to avoid this. Signed-off-by: Fuqian Huang ---