Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-25 Thread Greg Kroah-Hartman
On Tue, Aug 25, 2020 at 04:44:37PM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 25, 2020 at 10:39:46AM -0400, Alan Stern wrote: > > On Tue, Aug 25, 2020 at 08:51:35AM +0200, Greg Kroah-Hartman wrote: > > > At first glance, I think this can all be cleaned up, but it will take a > > > bit of tree-w

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-25 Thread Greg Kroah-Hartman
On Tue, Aug 25, 2020 at 10:39:46AM -0400, Alan Stern wrote: > On Tue, Aug 25, 2020 at 08:51:35AM +0200, Greg Kroah-Hartman wrote: > > At first glance, I think this can all be cleaned up, but it will take a > > bit of tree-wide work. I agree, we need a "read this message and error > > if the whole

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-25 Thread Alan Stern
On Tue, Aug 25, 2020 at 08:51:35AM +0200, Greg Kroah-Hartman wrote: > At first glance, I think this can all be cleaned up, but it will take a > bit of tree-wide work. I agree, we need a "read this message and error > if the whole thing is not there", as well as a "send this message and > error if

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Greg Kroah-Hartman
On Tue, Aug 25, 2020 at 08:51:35AM +0200, Greg Kroah-Hartman wrote: > On Mon, Aug 24, 2020 at 10:55:28AM +0200, Dmitry Vyukov wrote: > > On Sun, Aug 23, 2020 at 12:57 PM Greg Kroah-Hartman > > wrote: > > > > > > On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > > > > On Sun, Aug 23,

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Greg Kroah-Hartman
On Mon, Aug 24, 2020 at 10:55:28AM +0200, Dmitry Vyukov wrote: > On Sun, Aug 23, 2020 at 12:57 PM Greg Kroah-Hartman > wrote: > > > > On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > > > On Sun, Aug 23, 2020 at 12:19 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Sun, Aug 2

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Himadri Pandya
On Mon, Aug 24, 2020 at 11:16:55AM -0700, Jakub Kicinski wrote: > On Sun, 23 Aug 2020 13:50:42 +0530 Himadri Pandya wrote: > > Initialize the buffer before passing it to usb_read_cmd() function(s) to > > fix the uninit-was-stored issue in asix_read_cmd(). > > > > Fixes: KMSAN: kernel-infoleak in r

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Jakub Kicinski
On Sun, 23 Aug 2020 13:50:42 +0530 Himadri Pandya wrote: > Initialize the buffer before passing it to usb_read_cmd() function(s) to > fix the uninit-was-stored issue in asix_read_cmd(). > > Fixes: KMSAN: kernel-infoleak in raw_ioctl Regardless of the ongoing discussion - could you please make thi

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-24 Thread Dmitry Vyukov
On Sun, Aug 23, 2020 at 12:57 PM Greg Kroah-Hartman wrote: > > On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > > On Sun, Aug 23, 2020 at 12:19 PM Greg Kroah-Hartman > > wrote: > > > > > > On Sun, Aug 23, 2020 at 11:26:27AM +0200, Dmitry Vyukov wrote: > > > > On Sun, Aug 23, 2020

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-23 Thread Greg Kroah-Hartman
On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > On Sun, Aug 23, 2020 at 12:19 PM Greg Kroah-Hartman > wrote: > > > > On Sun, Aug 23, 2020 at 11:26:27AM +0200, Dmitry Vyukov wrote: > > > On Sun, Aug 23, 2020 at 10:21 AM Himadri Pandya > > > wrote: > > > > > > > > Initialize the bu

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-23 Thread Greg Kroah-Hartman
On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > On Sun, Aug 23, 2020 at 12:19 PM Greg Kroah-Hartman > > It's not always a failure, some devices have protocols that are "I could > > return up to a max X bytes but could be shorter" types of messages, so > > it's up to the caller to c

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-23 Thread Dmitry Vyukov
On Sun, Aug 23, 2020 at 12:19 PM Greg Kroah-Hartman wrote: > > On Sun, Aug 23, 2020 at 11:26:27AM +0200, Dmitry Vyukov wrote: > > On Sun, Aug 23, 2020 at 10:21 AM Himadri Pandya > > wrote: > > > > > > Initialize the buffer before passing it to usb_read_cmd() function(s) to > > > fix the uninit-wa

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-23 Thread Greg Kroah-Hartman
On Sun, Aug 23, 2020 at 11:26:27AM +0200, Dmitry Vyukov wrote: > On Sun, Aug 23, 2020 at 10:21 AM Himadri Pandya > wrote: > > > > Initialize the buffer before passing it to usb_read_cmd() function(s) to > > fix the uninit-was-stored issue in asix_read_cmd(). > > > > Fixes: KMSAN: kernel-infoleak i

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-23 Thread Dmitry Vyukov
On Sun, Aug 23, 2020 at 10:21 AM Himadri Pandya wrote: > > Initialize the buffer before passing it to usb_read_cmd() function(s) to > fix the uninit-was-stored issue in asix_read_cmd(). > > Fixes: KMSAN: kernel-infoleak in raw_ioctl > Reported by: syzbot+a7e220df5a81d1ab4...@syzkaller.appspotmail.

[PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-23 Thread Himadri Pandya
Initialize the buffer before passing it to usb_read_cmd() function(s) to fix the uninit-was-stored issue in asix_read_cmd(). Fixes: KMSAN: kernel-infoleak in raw_ioctl Reported by: syzbot+a7e220df5a81d1ab4...@syzkaller.appspotmail.com Signed-off-by: Himadri Pandya --- drivers/net/usb/asix_commo