Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread David Miller
From: Jeffrin Jose Date: Tue, 7 Aug 2012 19:30:20 +0530 > Fixed coding style issue relating to indentation in > net/appletalk/ddp.c found by checkpatch.pl tool > > Signed-off-by: Jeffrin Jose Please just stop trying to fix this code up, it's noise and you keep making mistakes. > case

Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread Joe Perches
On Tue, 2012-08-07 at 20:27 +0530, Jeffrin Jose wrote: > / Is putting "rc = put_user(amount, (int __user *)argp);" on the same > / indentation level as "amount = skb->len - sizeof(struct ddpehdr);" > / really what you want to do? > No. I was trying to place those lines at one > indentation back

Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread Jeffrin Jose
/ Is putting "rc = put_user(amount, (int __user *)argp);" on the same / indentation level as "amount = skb->len - sizeof(struct ddpehdr);" / really what you want to do? No. I was trying to place those lines at one indentation back from their current position. Thanks /Jeffrin. -- software

Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread Eric W. Biederman
Jeffrin Jose writes: > case TIOCINQ: { > /* >* These two are safe on a single CPU system as only >* user tasks fiddle here >*/ > - struct sk_buff *skb =

[PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread Jeffrin Jose
Fixed coding style issue relating to indentation in net/appletalk/ddp.c found by checkpatch.pl tool Signed-off-by: Jeffrin Jose --- net/appletalk/ddp.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/net/appletalk/ddp.c

[PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread Jeffrin Jose
Fixed coding style issue relating to indentation in net/appletalk/ddp.c found by checkpatch.pl tool Signed-off-by: Jeffrin Jose ahiliat...@yahoo.co.in --- net/appletalk/ddp.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git

Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread Eric W. Biederman
Jeffrin Jose ahiliat...@yahoo.co.in writes: case TIOCINQ: { /* * These two are safe on a single CPU system as only * user tasks fiddle here */ - struct sk_buff *skb =

Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread Jeffrin Jose
/ Is putting rc = put_user(amount, (int __user *)argp); on the same / indentation level as amount = skb-len - sizeof(struct ddpehdr); / really what you want to do? No. I was trying to place those lines at one indentation back from their current position. Thanks /Jeffrin. -- software engineer

Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread Joe Perches
On Tue, 2012-08-07 at 20:27 +0530, Jeffrin Jose wrote: / Is putting rc = put_user(amount, (int __user *)argp); on the same / indentation level as amount = skb-len - sizeof(struct ddpehdr); / really what you want to do? No. I was trying to place those lines at one indentation back from their

Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to

2012-08-07 Thread David Miller
From: Jeffrin Jose ahiliat...@yahoo.co.in Date: Tue, 7 Aug 2012 19:30:20 +0530 Fixed coding style issue relating to indentation in net/appletalk/ddp.c found by checkpatch.pl tool Signed-off-by: Jeffrin Jose ahiliat...@yahoo.co.in Please just stop trying to fix this code up, it's noise and