Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-03-04 Thread Dmitry Vyukov
On Wed, Mar 3, 2021 at 12:10 AM Jakub Kicinski wrote: > > On Tue, 2 Mar 2021 12:55:47 +0100 Dmitry Vyukov wrote: > > On Tue, Mar 2, 2021 at 10:06 AM Hillf Danton wrote: > > > On Mar 2, 2021 at 16:40 Dmitry Vyukov wrote: > > > >I hoped this would get at least into 5.12. syzbot can't start testing

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-03-03 Thread Jakub Kicinski
On Tue, 2 Mar 2021 12:55:47 +0100 Dmitry Vyukov wrote: > On Tue, Mar 2, 2021 at 10:06 AM Hillf Danton wrote: > > On Mar 2, 2021 at 16:40 Dmitry Vyukov wrote: > > >I hoped this would get at least into 5.12. syzbot can't start testing > > >arm32 because of this. FWIW the submission never got in

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-03-02 Thread Dmitry Vyukov
On Tue, Mar 2, 2021 at 10:06 AM Hillf Danton wrote: > > On Mar 2, 2021 at 16:40 Dmitry Vyukov wrote: > > >I hoped this would get at least into 5.12. syzbot can't start testing > > >arm32 because of this. > > > > Or what is more feasible is you send a fix to Jakub today. So far I can't figure out

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-03-02 Thread Dmitry Vyukov
On Fri, Jan 29, 2021 at 6:36 AM Hillf Danton wrote: > > On 29 Jan 2021 2:58:22 Jakub Kicinski wrpte: > > >On Thu, 28 Jan 2021 10:43:16 +0800 Hillf Danton wrote: > > >> Init the u64 stats in order to avoid the lockdep prints on the 32bit > > >> hardware like > > > > > >Thanks for the fix! > > > > H

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-01-28 Thread Dmitry Vyukov
On Thu, Jan 28, 2021 at 5:01 PM Eric Dumazet wrote: > > > > On 1/28/21 8:23 AM, Dmitry Vyukov wrote: > > On Thu, Jan 28, 2021 at 3:43 AM Hillf Danton wrote: > >> > >> Init the u64 stats in order to avoid the lockdep prints on the 32bit > >> hardware like > > > > FTR this is not just to avoid lock

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-01-28 Thread Eric Dumazet
On 1/28/21 8:23 AM, Dmitry Vyukov wrote: > On Thu, Jan 28, 2021 at 3:43 AM Hillf Danton wrote: >> >> Init the u64 stats in order to avoid the lockdep prints on the 32bit >> hardware like > > FTR this is not just to avoid lockdep prints, but also to prevent very > real stalls in production. Ar

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-01-27 Thread Dmitry Vyukov
On Thu, Jan 28, 2021 at 3:43 AM Hillf Danton wrote: > > Init the u64 stats in order to avoid the lockdep prints on the 32bit > hardware like FTR this is not just to avoid lockdep prints, but also to prevent very real stalls in production. u64_stats_init initializes seqlock, if the uninitialized s