David Hinds wrote:
>
> On Thu, Feb 15, 2001 at 10:49:22PM +1100, Andrew Morton wrote:
> >
> > Now, the thing I don't understand about David's design is the
> > final one. What 3c575_cb does is:
> >
> > CONFIG_HOTPLUG=y, MODULE=true
> > If the hardware isn't there, register the driver
On Thu, Feb 15, 2001 at 10:49:22PM +1100, Andrew Morton wrote:
>
> Now, the thing I don't understand about David's design is the
> final one. What 3c575_cb does is:
>
> CONFIG_HOTPLUG=y, MODULE=true
> If the hardware isn't there, register the driver and
> hang around.
>
>
Manfred Spraul wrote:
>
> David Hinds wrote:
> >
> > Say the driver is linked into the kernel. Hot plug drivers should not
> > all complain about not finding their hardware.
> >
>
> That's handled by pci_module_init(), check :
> if CONFIG_HOTPLUG is enabled, then pci_module_init() never
Manfred Spraul wrote:
David Hinds wrote:
Say the driver is linked into the kernel. Hot plug drivers should not
all complain about not finding their hardware.
That's handled by pci_module_init(), check linux/pci.h:
if CONFIG_HOTPLUG is enabled, then pci_module_init() never returns
On Thu, Feb 15, 2001 at 10:49:22PM +1100, Andrew Morton wrote:
Now, the thing I don't understand about David's design is the
final one. What 3c575_cb does is:
CONFIG_HOTPLUG=y, MODULE=true
If the hardware isn't there, register the driver and
hang around.
Why?
David Hinds wrote:
On Thu, Feb 15, 2001 at 10:49:22PM +1100, Andrew Morton wrote:
Now, the thing I don't understand about David's design is the
final one. What 3c575_cb does is:
CONFIG_HOTPLUG=y, MODULE=true
If the hardware isn't there, register the driver and
David Hinds wrote:
>
> Say the driver is linked into the kernel. Hot plug drivers should not
> all complain about not finding their hardware.
>
That's handled by pci_module_init(), check :
if CONFIG_HOTPLUG is enabled, then pci_module_init() never returns with
-ENODEV.
Which means that eisa
On Wed, 14 Feb 2001, David Hinds wrote:
> On Thu, Feb 15, 2001 at 12:33:43AM +1100, Andrew Morton wrote:
> >
> > > * something is wrong in the vortex initialization: I don't have such a
> > > card, but the driver didn't return an error message on insmod. I'm not
> > > sure if my fix is correct.
On Thu, Feb 15, 2001 at 12:33:43AM +1100, Andrew Morton wrote:
>
> > * something is wrong in the vortex initialization: I don't have such a
> > card, but the driver didn't return an error message on insmod. I'm not
> > sure if my fix is correct.
>
> That was intentional - dhinds suggested that
Em Wed, Feb 14, 2001 at 05:54:34AM -0600, Jeff Garzik escreveu:
> On Wed, 14 Feb 2001, Manfred Spraul wrote:
> > * dev->mem_start: NULL means "not command line configuration" 0x
> > means "default".
> > several drivers only check for NULL, not for 0x.
>
> netdev->mem_start is
Manfred Spraul wrote:
>
> I found 2 bugs in several network drivers:
>
> * dev->mem_start: NULL means "not command line configuration" 0x
> means "default".
> several drivers only check for NULL, not for 0x.
I think that's worth another "ewww...", don't you?
> * something is
On Wed, 14 Feb 2001, Manfred Spraul wrote:
> * something is wrong in the vortex initialization: I don't have such a
> card, but the driver didn't return an error message on insmod. I'm not
> sure if
> my fix is correct.
> @@ -2661,9 +2661,12 @@
>
> rc = pci_module_init(_driver);
>
On Wed, 14 Feb 2001, Manfred Spraul wrote:
> * dev->mem_start: NULL means "not command line configuration" 0x
> means "default".
> several drivers only check for NULL, not for 0x.
netdev->mem_start is unsigned long... Should the test be for ~0 instead?
The value 0x seems
I found 2 bugs in several network drivers:
* dev->mem_start: NULL means "not command line configuration" 0x
means "default".
several drivers only check for NULL, not for 0x.
* incorrect bounds checks for phy_idx: 2 entries in the structure, but
up to 4 are initialized.
*
I found 2 bugs in several network drivers:
* dev-mem_start: NULL means "not command line configuration" 0x
means "default".
several drivers only check for NULL, not for 0x.
* incorrect bounds checks for phy_idx: 2 entries in the structure, but
up to 4 are initialized.
*
On Wed, 14 Feb 2001, Manfred Spraul wrote:
* dev-mem_start: NULL means "not command line configuration" 0x
means "default".
several drivers only check for NULL, not for 0x.
netdev-mem_start is unsigned long... Should the test be for ~0 instead?
The value 0x seems wrong
On Wed, 14 Feb 2001, Manfred Spraul wrote:
* something is wrong in the vortex initialization: I don't have such a
card, but the driver didn't return an error message on insmod. I'm not
sure if
my fix is correct.
@@ -2661,9 +2661,12 @@
rc = pci_module_init(vortex_driver);
Manfred Spraul wrote:
I found 2 bugs in several network drivers:
* dev-mem_start: NULL means "not command line configuration" 0x
means "default".
several drivers only check for NULL, not for 0x.
I think that's worth another "ewww...", don't you?
* something is wrong in
Em Wed, Feb 14, 2001 at 05:54:34AM -0600, Jeff Garzik escreveu:
On Wed, 14 Feb 2001, Manfred Spraul wrote:
* dev-mem_start: NULL means "not command line configuration" 0x
means "default".
several drivers only check for NULL, not for 0x.
netdev-mem_start is unsigned
On Thu, Feb 15, 2001 at 12:33:43AM +1100, Andrew Morton wrote:
* something is wrong in the vortex initialization: I don't have such a
card, but the driver didn't return an error message on insmod. I'm not
sure if my fix is correct.
That was intentional - dhinds suggested that if the
On Wed, 14 Feb 2001, David Hinds wrote:
On Thu, Feb 15, 2001 at 12:33:43AM +1100, Andrew Morton wrote:
* something is wrong in the vortex initialization: I don't have such a
card, but the driver didn't return an error message on insmod. I'm not
sure if my fix is correct.
That
David Hinds wrote:
Say the driver is linked into the kernel. Hot plug drivers should not
all complain about not finding their hardware.
That's handled by pci_module_init(), check linux/pci.h:
if CONFIG_HOTPLUG is enabled, then pci_module_init() never returns with
-ENODEV.
Which means that
22 matches
Mail list logo
