Re: [PATCH] nilfs2: only call unlock_new_inode() if I_NEW

2020-07-27 Thread Ryusuke Konishi
Yeah, I sent this to Andrew a little while ago: https://lkml.org/lkml/2020/7/27/976 Thanks, Ryusuke Konishi On Tue, Jul 28, 2020 at 1:50 AM Eric Biggers wrote: > > On Sun, Jun 28, 2020 at 12:01:52AM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > unlock_new_inode() is only meant

Re: [PATCH] nilfs2: only call unlock_new_inode() if I_NEW

2020-07-27 Thread Eric Biggers
On Sun, Jun 28, 2020 at 12:01:52AM -0700, Eric Biggers wrote: > From: Eric Biggers > > unlock_new_inode() is only meant to be called after a new inode has > already been inserted into the hash table. But nilfs_new_inode() can > call it even before it has inserted the inode, triggering the

[PATCH] nilfs2: only call unlock_new_inode() if I_NEW

2020-06-28 Thread Eric Biggers
From: Eric Biggers unlock_new_inode() is only meant to be called after a new inode has already been inserted into the hash table. But nilfs_new_inode() can call it even before it has inserted the inode, triggering the WARNING in unlock_new_inode(). Fix this by only calling unlock_new_inode()