Re: [PATCH] nios2: fix error handling of irq_of_parse_and_map

2014-11-17 Thread Ley Foon Tan
On Mon, Nov 17, 2014 at 5:24 PM, Tobias Klauser wrote: > On 2014-11-14 at 23:04:19 +0100, Dmitry Torokhov wrote: >> Return value of irq_of_parse_and_map() is unsigned int, with 0 >> indicating failure, so testing for negative result never works. >> >> Signed-off-by: Dmitry Torokhov > > Reviewed-

Re: [PATCH] nios2: fix error handling of irq_of_parse_and_map

2014-11-17 Thread Tobias Klauser
On 2014-11-14 at 23:04:19 +0100, Dmitry Torokhov wrote: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Tobias Klauser Thanks for catching this. -- To unsubscribe

[PATCH] nios2: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov --- Not tested, found by casual code inspection. arch/nios2/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --