Re: [PATCH] nvme: explicitly disable APST on quirked devices

2017-06-24 Thread Andy Lutomirski
On Sat, Jun 24, 2017 at 12:47 AM, Kai-Heng Feng wrote: > On Sat, Jun 24, 2017 at 1:17 AM, Andy Lutomirski wrote: >> On Thu, Jun 22, 2017 at 11:19 PM, Kai-Heng Feng >> wrote: >>> A user reports APST is enabled, even when

Re: [PATCH] nvme: explicitly disable APST on quirked devices

2017-06-24 Thread Andy Lutomirski
On Sat, Jun 24, 2017 at 12:47 AM, Kai-Heng Feng wrote: > On Sat, Jun 24, 2017 at 1:17 AM, Andy Lutomirski wrote: >> On Thu, Jun 22, 2017 at 11:19 PM, Kai-Heng Feng >> wrote: >>> A user reports APST is enabled, even when the NVMe is quirked or with >>> option "default_ps_max_latency_us=0". >>>

Re: [PATCH] nvme: explicitly disable APST on quirked devices

2017-06-24 Thread Kai-Heng Feng
On Sat, Jun 24, 2017 at 1:17 AM, Andy Lutomirski wrote: > On Thu, Jun 22, 2017 at 11:19 PM, Kai-Heng Feng > wrote: >> A user reports APST is enabled, even when the NVMe is quirked or with >> option "default_ps_max_latency_us=0". >> >> The current

Re: [PATCH] nvme: explicitly disable APST on quirked devices

2017-06-24 Thread Kai-Heng Feng
On Sat, Jun 24, 2017 at 1:17 AM, Andy Lutomirski wrote: > On Thu, Jun 22, 2017 at 11:19 PM, Kai-Heng Feng > wrote: >> A user reports APST is enabled, even when the NVMe is quirked or with >> option "default_ps_max_latency_us=0". >> >> The current logic will not set APST if the device is quirked.

Re: [PATCH] nvme: explicitly disable APST on quirked devices

2017-06-23 Thread Andy Lutomirski
On Thu, Jun 22, 2017 at 11:19 PM, Kai-Heng Feng wrote: > A user reports APST is enabled, even when the NVMe is quirked or with > option "default_ps_max_latency_us=0". > > The current logic will not set APST if the device is quirked. But the > NVMe in question will

Re: [PATCH] nvme: explicitly disable APST on quirked devices

2017-06-23 Thread Andy Lutomirski
On Thu, Jun 22, 2017 at 11:19 PM, Kai-Heng Feng wrote: > A user reports APST is enabled, even when the NVMe is quirked or with > option "default_ps_max_latency_us=0". > > The current logic will not set APST if the device is quirked. But the > NVMe in question will enable APST automatically. > >

[PATCH] nvme: explicitly disable APST on quirked devices

2017-06-23 Thread Kai-Heng Feng
A user reports APST is enabled, even when the NVMe is quirked or with option "default_ps_max_latency_us=0". The current logic will not set APST if the device is quirked. But the NVMe in question will enable APST automatically. Separate the logic "apst is supported" and "to enable apst", so we

[PATCH] nvme: explicitly disable APST on quirked devices

2017-06-23 Thread Kai-Heng Feng
A user reports APST is enabled, even when the NVMe is quirked or with option "default_ps_max_latency_us=0". The current logic will not set APST if the device is quirked. But the NVMe in question will enable APST automatically. Separate the logic "apst is supported" and "to enable apst", so we