Re: [PATCH] nvme-core: don't initlialize ctrl->cntlid twice

2019-01-09 Thread Christoph Hellwig
Thanks, applied to nvme-4.21.

Re: [PATCH] nvme-core: don't initlialize ctrl->cntlid twice

2019-01-08 Thread Keith Busch
On Mon, Jan 07, 2019 at 07:08:49PM -0800, Andrey Smirnov wrote: > ctrl->cntlid will already be initialized from id->cntlid for > non-NVME_F_FABRICS controllers few lines below. For NVME_F_FABRICS > controllers this field should already be initialized, otherwise the > check > > if

Re: [PATCH] nvme-core: don't initlialize ctrl->cntlid twice

2019-01-08 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

[PATCH] nvme-core: don't initlialize ctrl->cntlid twice

2019-01-07 Thread Andrey Smirnov
ctrl->cntlid will already be initialized from id->cntlid for non-NVME_F_FABRICS controllers few lines below. For NVME_F_FABRICS controllers this field should already be initialized, otherwise the check if (ctrl->cntlid != le16_to_cpu(id->cntlid)) below will always be a no-op. Cc: Keith