Re: [PATCH] nvme-pci: Avoid leak if pci_p2pmem_virt_to_bus() returns null

2019-06-25 Thread Alan Mikhak
On Tue, Jun 25, 2019 at 10:10 AM Heitke, Kenneth wrote: > > > > On 6/24/2019 5:57 PM, Alan Mikhak wrote: > > Modify nvme_alloc_sq_cmds() to call pci_free_p2pmem() > > to free the memory it allocated using pci_alloc_p2pmem() > > in case pci_p2pmem_virt_to_bus() returns null. > > > > Make sure not

Re: [PATCH] nvme-pci: Avoid leak if pci_p2pmem_virt_to_bus() returns null

2019-06-25 Thread Alan Mikhak
On Tue, Jun 25, 2019 at 12:09 AM Christoph Hellwig wrote: > > On Mon, Jun 24, 2019 at 04:57:22PM -0700, Alan Mikhak wrote: > > Modify nvme_alloc_sq_cmds() to call pci_free_p2pmem() > > to free the memory it allocated using pci_alloc_p2pmem() > > in case pci_p2pmem_virt_to_bus() returns null. > >

Re: [PATCH] nvme-pci: Avoid leak if pci_p2pmem_virt_to_bus() returns null

2019-06-25 Thread Heitke, Kenneth
On 6/24/2019 5:57 PM, Alan Mikhak wrote: Modify nvme_alloc_sq_cmds() to call pci_free_p2pmem() to free the memory it allocated using pci_alloc_p2pmem() in case pci_p2pmem_virt_to_bus() returns null. Make sure not to call pci_free_p2pmem() if pci_alloc_p2pmem() returned null which can happen

Re: [PATCH] nvme-pci: Avoid leak if pci_p2pmem_virt_to_bus() returns null

2019-06-25 Thread Christoph Hellwig
On Mon, Jun 24, 2019 at 04:57:22PM -0700, Alan Mikhak wrote: > Modify nvme_alloc_sq_cmds() to call pci_free_p2pmem() > to free the memory it allocated using pci_alloc_p2pmem() > in case pci_p2pmem_virt_to_bus() returns null. > > Make sure not to call pci_free_p2pmem() if pci_alloc_p2pmem() >

[PATCH] nvme-pci: Avoid leak if pci_p2pmem_virt_to_bus() returns null

2019-06-24 Thread Alan Mikhak
Modify nvme_alloc_sq_cmds() to call pci_free_p2pmem() to free the memory it allocated using pci_alloc_p2pmem() in case pci_p2pmem_virt_to_bus() returns null. Make sure not to call pci_free_p2pmem() if pci_alloc_p2pmem() returned null which can happen if CONFIG_PCI_P2PDMA is not configured.