Re: [PATCH] nvme-pci: mark expected switch fall-through

2019-05-08 Thread Gustavo A. R. Silva
On 5/8/19 2:18 AM, Christoph Hellwig wrote: > Thanks, > > applied to nvme-5.2. > Great. :) Thanks, Christoph. -- Gustavo

Re: [PATCH] nvme-pci: mark expected switch fall-through

2019-05-08 Thread Christoph Hellwig
Thanks, applied to nvme-5.2.

Re: [PATCH] nvme-pci: mark expected switch fall-through

2019-05-07 Thread Chaitanya Kulkarni
Looks good. Reviewed-by: Chaitanya Kulkarni On 5/7/19 7:23 AM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/nvme/host/pci.c: In function

Re: [PATCH] nvme-pci: mark expected switch fall-through

2019-05-07 Thread Keith Busch
On Tue, May 07, 2019 at 09:23:00AM -0500, Gustavo A. R. Silva wrote: > @@ -1296,6 +1296,7 @@ static enum blk_eh_timer_return nvme_timeout(struct > request *req, bool reserved) > switch (dev->ctrl.state) { > case NVME_CTRL_DELETING: > shutdown = true; > + /*

[PATCH] nvme-pci: mark expected switch fall-through

2019-05-07 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/nvme/host/pci.c: In function ‘nvme_timeout’: drivers/nvme/host/pci.c:1298:12: warning: this statement may fall through