Re: [Ocfs2-devel] [PATCH] ocfs2: Remove unneeded return variable

Actually I think the macro of map_flag() is ugly. Yang may want to fix that first. Thanks, Wengang On 2/3/21 9:12 PM, Joseph Qi wrote: NAK. This was discussed before, please refer: https://oss.oracle.com/pipermail/ocfs2-devel/2020-April/014969.html Thanks, Joseph On 2/4/21 11:12 AM, Yang Li

Re: [PATCH] ocfs2: Remove unneeded return variable

NAK. This was discussed before, please refer: https://oss.oracle.com/pipermail/ocfs2-devel/2020-April/014969.html Thanks, Joseph On 2/4/21 11:12 AM, Yang Li wrote: > This patch removes unneeded return variables, using only > '0' instead. > It fixes the following warning detected by coccinelle: >

Re: [PATCH] ocfs2: Remove unneeded return variable

Hi Yang, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.11-rc6 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

[PATCH] ocfs2: Remove unneeded return variable

This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./fs/ocfs2/stack_o2cb.c:69:5-16: Unneeded variable: "o2dlm_flags". Return "0" on line 84 Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/ocfs2/stack_o2cb.c | 4